Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] Selective API response marshalling #90

Closed
mukul-mehta opened this issue Aug 25, 2019 · 2 comments · Fixed by #89

Comments

@mukul-mehta
Copy link
Contributor

commented Aug 25, 2019

As of now, the login response returns all responses with the login_info DTO. In the future, we want it to marshall it only when the response is 200. In the rest of the cases, it should return a normal response object.

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 25, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@mukul-mehta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

We'll need to add a decorator that marshalls only when the response is 200.

grapheo12 added a commit to grapheo12/common-backend that referenced this issue Aug 25, 2019
thealphadollar added a commit that referenced this issue Aug 25, 2019
[WIP] Marathon Bug Hunt (#89)
* Added endpoint for accessing saved articles

* Update user_controller.py

* Update user_controller.py

remove unnecessary import

* Added Get All endpoint for articles

* Added unsaving feature

* Fixes #86

* Fixes #84

* Moved image related operations to separate Namespace

* Fixes #90

* Update auth_controller.py

* Update auth_service.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.