Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead? #1234

Closed
Suburbanno opened this issue Sep 10, 2017 · 7 comments
Closed

dead? #1234

Suburbanno opened this issue Sep 10, 2017 · 7 comments

Comments

@Suburbanno
Copy link

@Suburbanno Suburbanno commented Sep 10, 2017

No description provided.

@nhamer
Copy link

@nhamer nhamer commented Sep 12, 2017

resting

@SignFinder
Copy link

@SignFinder SignFinder commented Jan 7, 2018

Can someone fork the project and produce the release with the fixes? IITC doesn't work with new FF after 2 monthes already.

@JonnyTech
Copy link

@JonnyTech JonnyTech commented Jan 7, 2018

What doesn't work? No problem here running IITC with Firefox 57.0.4 using Violentmonkey and many IITC plugins. Can you be more specific?

@SignFinder
Copy link

@SignFinder SignFinder commented Jan 8, 2018

Sure, I can. Not me directly.
#1249

@JonnyTech
Copy link

@JonnyTech JonnyTech commented Jan 8, 2018

Ah, they are using Greasemonkey. As I said, I use Violentmonkey. It works flawlessly for me.

What exactly is not working? Please provide specific examples with details.

@SignFinder
Copy link

@SignFinder SignFinder commented Jan 14, 2018

@JonnyTech
Greasemonkey 4.0 changed the API which is used by the script. This change is backwards incompatible as written in the announcement: https://www.greasespot.net/2017/09/greasemonkey-4-announcement.html

So, every script using one of these functions needs to adapt to this new API to continue working. As long as a script is not adapted, it will not work.

@JohnCalin
Copy link

@JohnCalin JohnCalin commented Apr 6, 2018

I've resolved this in my own system. Not sure the best way to suggest the updated code here, so I'll just post it.

Change this:
if (typeof(window.PLAYER)!="object" || typeof(window.PLAYER.nickname) != "string") {

To this:
if (typeof(unsafeWindow.PLAYER)!="object" || typeof(unsafeWindow.PLAYER.nickname) != "string") {

I hope this helps.

@Suburbanno Suburbanno closed this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants