New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch zoom hangs #257

Open
RabidArts opened this Issue May 9, 2013 · 47 comments

Comments

Projects
None yet
@RabidArts

RabidArts commented May 9, 2013

Using Mobile, I'm completely unable to pinch zoom.
After lifting my fingers, the portals disappear, and the status remains "paused during interaction".
Seems that the end of the pinch zoom action is not detected.

I'm running stock android 4.1.1 on a Samsung N7100 (Note 2).

I've tried the 0.3.6 test build and 0.3.2 stable, and both exhibit this, with the stable release giving me issues with the zoom buttons in addition.

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 9, 2013

I've noticed certain interactions result in that and plan to look into it when I get the chance.

If you hit refresh or move the map it tends to work as a temporary workaround.

@RabidArts

This comment has been minimized.

RabidArts commented May 9, 2013

Thanks for the quick reply.

Unfortunately, those workarounds don't work in this case .. panning is unresponsive when this has happened, and a forced refresh will take me back to the original extents, rendering the pinch zoom useless.

@jonatkins

This comment has been minimized.

Collaborator

jonatkins commented May 10, 2013

just for reference, I very occasionally get the 'paused during interaction' using chrome on my desktop PC.

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 12, 2013

Once #268 is merged you may like to try a test build to see if this is fixed.

@RabidArts

This comment has been minimized.

RabidArts commented May 12, 2013

Did a reinstall now, just to check, but still broken.

The behavior is slightly different though, previously the map would not zoom in and the portals would disappear.
Now the map zooms in, but doesn't update to more detail. The status still remains "paused during user interaction"

Will keep an eye on the commits for the mobile render limit changes.

@wernicke81

This comment has been minimized.

Contributor

wernicke81 commented May 22, 2013

Try using the +/- buttons until pinch zoom is fixed.

@RabidArts

This comment has been minimized.

RabidArts commented May 22, 2013

Yup that's what I'll be doing.
The latest nightly seems very smooth aside from the pinch zoom issue.

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 22, 2013

@RabidArts just for the record...does double tap to zoom works for you?

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 22, 2013

@RabidArts Can you check pinch-to-zoom with the latest version and all plugins and display user location turned off?

If it works can you please try turning one plugin on at a time to see if it's a particular plugin, or perhaps just the number of total active plugins, causing the issue.

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 23, 2013

@RabidArts could you please check http://iitcm.code-noobs.org/iitc_pinch_to_zoom_debug5.apk if it fixes your pinch2zoom bug?

@RabidArts

This comment has been minimized.

RabidArts commented May 23, 2013

@hastarin I tried both the latest and test release and unfortunately both fail.

Interestingly the status message on the release version seems to respond properly but the portals on the map disappear and wont come back, and no more zooming is possible.
Usually both freeze up.

Struggling to get the buttons to work too.

@leCradle Unfortunately double tap also won't work.
I tried the debug version and it also doesn't seem to work... and neither do the zoom buttons. :-(

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 23, 2013

@RabidArts portals disappear? With google layers too?

Can you test some builds on http://iitcm.code-noobs.org ?
Which is the latest version that works for you?
Hint: try these first http://iitcm.code-noobs.org/IITC-Mobile-2013-05-09-143915.apk and http://iitcm.code-noobs.org/IITC-Mobile-2013-05-12-220049.apk
If both version do well, please check later versions....
Would be a big help for us since we can't reproduce the bug. Thx

@jonatkins

This comment has been minimized.

Collaborator

jonatkins commented May 23, 2013

portals disappearing could be an instance of #90 - the map layer appearing on top of everything else. Do the zoom controls, status panel, etc also disappear?

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 23, 2013

If it works for google layers (I have this problem when zooming out in areas with high portal density) it could be an instance of Leaflet/Leaflet#1698

@RabidArts

This comment has been minimized.

RabidArts commented May 23, 2013

Thanks so far guys.

I'm running through a bunch of tests on a few versions now - so far I've picked up that there is a distinct difference in symptoms depending on what base layer I'm using.

So far, it looks like the default ingress map layer works a little better (I can double tap and use the zoom buttons, while the MapQuest OSM layer doesn't let me do this). Still no pinch zoom on either though.

@jonatkins The zoom controls and status panel do not disappear - only the portals.

@leCradle That leaflet description sounds quite plausible and similar, except this isn't an occasional thing that happens, it's consistent whenever I pinch zoom.

@RabidArts

This comment has been minimized.

RabidArts commented May 23, 2013

Please see my test results shared here

In short, all versions exhibit the same problem on this phone, as far back as I can test.
It's a relatively new phone, Samsung Galaxy Note 2 (N7100).
And it's still running a stock OS - Android 4.1.1, rooted.

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 23, 2013

@RabidArts Thanks for all the testing. Can you please also try the map here:
http://leafletjs.com/

I'm curious if it exhibits the same/similar symptoms.

@RabidArts

This comment has been minimized.

RabidArts commented May 24, 2013

Happy to help :-)
That map seems to work correctly (it remains responsive after pinch zooming)
On 24 May 2013 01:39, "Jon" notifications@github.com wrote:

@RabidArts https://github.com/RabidArts Thanks for all the testing. Can
you please also try the map here:
http://leafletjs.com/

I'm curious if it exhibits the same/similar symptoms.


Reply to this email directly or view it on GitHubhttps://github.com//issues/257#issuecomment-18378562
.

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 25, 2013

@RabidArts Can you please try this APK https://www.dropbox.com/s/lbuf1bodqemihfs/WebViewNote2Test.apk

It's simply displaying http://leafletjs.com/examples/mobile-example.html in a basic WebView with Javascript enabled.

If that works then it's something that's being done in IITC somewhere that's breaking it. If that doesn't work then the issue is in WebView/Leaflet and therefore out of our control.

Thanks in advance.

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 25, 2013

Actually I managed to get my brother to test the above and another attempted workaround but both failed.

We'll just have to hope it eventually gets a fix in Leaflet.
See Leaflet/Leaflet#1182

@leCradle @jonatkins It's up to you guys but I'd suggest marking this as Won't Fix. :(

@RabidArts

This comment has been minimized.

RabidArts commented May 25, 2013

I tried to install the test apk but I get 'cannot parse package'

I believe there are 2 issues :
#1 leaflet pinch zoom on note 2
#2 mapquest osm base layer cant zoom at all

For #1 can someone report it to them?

Thanks everyone!

Edit: nevermind... somehow didn't see that ticket

On 25 May 2013 07:57, "Jon" notifications@github.com wrote:

Actually I managed to get my brother to test the above and another
attempted workaround but both failed.

We'll just have to hope it eventually gets a fix in Leaflet.
See Leaflet/Leaflet#1182 Leaflet/Leaflet#1182

@leCradle https://github.com/leCradle @jonatkinshttps://github.com/jonatkinsIt's up to you guys but I'd suggest marking this as Won't Fix. :(


Reply to this email directly or view it on GitHubhttps://github.com//issues/257#issuecomment-18440295
.

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 25, 2013

Well...we need a dev who

  • can reproduce the problem
  • has the android sdk installed
  • has a few hours to bisect through the git commits to find the broken commit
    But the main problem is, that the bug behaves different on different devices.
    For some people it magically disappears, for some people the leaflet downgrade did the trick, for some people it does not work on any build...

oh @RabidArts can you do one more check?
Install the latest build and disable all overlay layers. Does this work for you? I know that no overlay layers is not an option but it could be a hint in the right direction..

@RabidArts

This comment has been minimized.

RabidArts commented May 25, 2013

I turned off all overlay layers, but no change in behaviour.. tried
multiple base layers.

I happen to be a developer, so can take a stab at setting up my system to
debug it.
On 25 May 2013 14:20, "Philipp Schaefer" notifications@github.com wrote:

Well...we need a dev who

  • can reproduce the problem
  • has the android sdk installed
  • has a few hours to bisect through the git commits to find the broken
    commit But the main problem is, that the bug behaves different on different
    devices. For some people it magically disappears, for some people the
    leaflet downgrade did the trick, for some people it does not work on any
    build...

oh @RabidArts https://github.com/RabidArts can you do one more check?
Install the latest build and disable all overlay layers. Does this work
for you? I know that no overlay layers is not an option but it could be a
hint in the right direction..


Reply to this email directly or view it on GitHubhttps://github.com//issues/257#issuecomment-18446277
.

@markfguerra

This comment has been minimized.

Contributor

markfguerra commented May 25, 2013

I can definitely reproduce this on my Nexus 4 and other devices. My dev environment is set up as well.

@leCradle Do we have a known good commit that I can use with git bisect?

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 25, 2013

@markfguerra odd. I have a Nexus4 too and have no problems so far...but thx for your help!
Regarding the last good commit: v0.3.2 was released on 2nd May and no one complaint about a pinch to zoom issue. So I think this one 0391670 should be a good point to start git bisect.

@markfguerra

This comment has been minimized.

Contributor

markfguerra commented May 25, 2013

@leCradle are you in a major metro area? Just a hunch, but it seems to happen when there are a lot of portals around.

@RabidArts

This comment has been minimized.

RabidArts commented May 25, 2013

Also interesting... I'm with a friend and his note 2 works fine with the
latest release and all previous releases
On 25 May 2013 18:39, "Philipp Schaefer" notifications@github.com wrote:

@markfguerra https://github.com/markfguerra odd. I have a Nexus4 too
and have no problems so far...but thx for your help!
Regarding the last good commit: v0.3.2 was released on 2nd May and no one
complaint about a pinch to zoom issue. So I think this one 03916700391670 be a good point to start git bisect.


Reply to this email directly or view it on GitHubhttps://github.com//issues/257#issuecomment-18450021
.

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 25, 2013

@markfguerra
No I am not. But I get issues too when viewing areas with high portal density. But only with OSM layers...this is another issue und is caused by a leaflet bug...I linked it above.
With Google layers I have no problems at all.
But other people hinted that they can't pinch2zoom in every area...this is the problem we are focussing here.

@leCradle

This comment has been minimized.

Collaborator

leCradle commented May 25, 2013

@RabidArts thx for the hint.
Do you have the same ROM running on your devices?
All people so far reported that they are on a Samsung stock rom....iirc.

@markfguerra

This comment has been minimized.

Contributor

markfguerra commented May 25, 2013

@leCradle As of yesterday I was one of those people who had those hanging issues, even while zoomed in to an area of low portal density.

When I ran using 0391670, I had to remove the app via the Android GUI due to the INSTALL_FAILED_VERSION_DOWNGRADE error. I then launched and logged in again with my google account. The app worked smoothly at 0391670, with some small lags that didn't seem related to the main issue. I was convinced this was a good version to use with bisect.

I went on to re-test with the version I last used in the field, b05554e. I noticed that, after re-install, even b05554e was working fairly well. That's really odd, because when I was playing last night IITC was barely usable. It's possible that clearing the app's data by the reinstall affected the outcome of the test.

I can still trigger the issue sometimes but not as easily or reliably as yesterday. At that time, nearly every pinch, and even sometimes panning the map, resulted in a hang.

@hastarin

This comment has been minimized.

Contributor

hastarin commented May 26, 2013

Interestingly I just had the issue on my Nexus 7 and I uninstalled and reinstalled the app and it started working again.

Very strange. Perhaps there are multiple issues with a similar symptom.

@markfguerra

This comment has been minimized.

Contributor

markfguerra commented May 28, 2013

I started experiencing the issue again after a few days using it in the field.

To diagnose, I terminated the app using the Android task switcher and used the Android app management GUI to clear the cache for IITC. There was no effect; the app was still unresponsive.

I then used the same GUI to clear all application data for IITC, requiring me to login again to use the map. This, for the time being, mitigated the issue; scrolling and pinch zooming became responsive again.

@helllo

This comment has been minimized.

helllo commented Jun 9, 2013

Quicky update from a Galaxy Tab 7.0 user (gt-p6200) with android 4.1.2 stock rom:
Testbuild 0.4.6 bugfixed the pinch to zoom issue for me, which was present since 0.4 and up.

@leCradle

This comment has been minimized.

Collaborator

leCradle commented Jun 9, 2013

@helllo thanks for the info. Best part of it is, that we didn't do anything against this issue (or did we?)...magic woohoo...^^

@jonatkins

This comment has been minimized.

Collaborator

jonatkins commented Jun 9, 2013

@leCradle I did update Leaflet a week or so ago - might have helped?

@jonatkins

This comment has been minimized.

Collaborator

jonatkins commented Jun 11, 2013

Not certain if this is the samew issue, or something separate, but I had the following comment on the IITC page

"I have identified when the multi touch commands stop working in the application is when I use the GPS location. If I have the app find me on the phone instead of manually finding a location or using the search feature, Multi touch commands for zoom stop working."

@Scavanger

This comment has been minimized.

Scavanger commented Jun 11, 2013

Zoom still don't work on my Note II with stock rom.

Not really a solution:
I tried to run IITC as a user script under some Android Browsers (Chrome, Tampermonkey for Android, Opera (Classic)).
The only solution is to convert it into an addon for Firefox mobile. Pinch to zoom works here but it has some disadvantages:

  • No Plugins
  • No Setting
  • Switching between layers worked faithless

But I can use IITC on my phone. :)

@leCradle

This comment has been minimized.

Collaborator

leCradle commented Jun 12, 2013

@jonatkins I don't get his point.
"If I have the app find me on the phone instead of manually finding a location or using the search feature [...]"
This implies he means the "get location" button, but this is no GPS location...so...did he mean the GPS-location (display user location) or the "get location" stuff?

Can anyone confirm this location-pinch2zoom coherence?

@leCradle

This comment has been minimized.

Collaborator

leCradle commented Jun 12, 2013

@Scavanger this is really interesting. How did you convert the script?

@Scavanger

This comment has been minimized.

Scavanger commented Jun 12, 2013

@leCradle:

This is very easy. I used page-mod (https://addons.mozilla.org/en-US/developers/docs/sdk/1.14/modules/sdk/page-mod.html) put it together with the IITC script and compiled the whole thing with the Mozilla addon SDK for FF mobile.

I made only to small hacks:

  • Bring back the layer chooser
  • Use the X in the portal info to close the whole view.

You can find the source code and the compiled addon (xpi file) here: https://github.com/Scavanger/IITCFirefoxAddOn

@nathanstretch

This comment has been minimized.

nathanstretch commented Jun 24, 2013

I was having this same problem until I turned show user location on. Only with user location on am I able to pinch zoom. No other plugins are installed. This is on a Galaxy S4, with IITC build 0.4.6, version 0.12.1.20130612.162306.

@egyptianbman

This comment has been minimized.

egyptianbman commented Aug 23, 2013

Thank you @nathanstretch! I've been having this issue for months and turning show use location did fix the issue.

@markdeaton

This comment has been minimized.

markdeaton commented Aug 23, 2013

I've been having the pinch/zoom problem also, on a Samsung Galaxy S2, AOKP. (Android browser installed, Chrome not installed.) I noticed that...

  1. After I first installed the app, pinch/zoom worked just fine.
  2. After a short while (very likely after I first used the "find location" feature as noted above) it stopped working and would freeze the app when I tried.
  3. Enabling "show user location" does make it work again but with one difference. Before, the map and markers would enlarge dynamically as I used the pinch-open gesture to zoom in. Now nothing moves on the screen until I finish the gesture and remove my fingers from the screen, at which point, the zoom happens. While it's useful as-is, it was still more useful to have the dynamic visual indicator of the degree to which I was zooming.
@leCradle

This comment has been minimized.

Collaborator

leCradle commented Nov 10, 2013

FYI issue is reported to leaflet, but ignored until now Leaflet/Leaflet#1759

@sosnet

This comment has been minimized.

sosnet commented Nov 11, 2013

As written in #636 I have problems with zooming in/out on my nex5 on Android 4.4
I figured out, that this problem appears only when using google-maps, not with OSM.

The map freezes on "map: pause"

fkloft added a commit to fkloft/ingress-intel-total-conversion that referenced this issue Dec 2, 2013

Website: update mobile download and faq page
- Android login is disabled now
- issue iitc-project#90 is closed
- mention issue iitc-project#257
@fab1an

This comment has been minimized.

fab1an commented Jun 13, 2014

Check this out pls: Leaflet/Leaflet#2693 (comment)

@wjwolf79

This comment has been minimized.

wjwolf79 commented Nov 8, 2014

I kind of did a quick read through of this. I have this issue, a lot. On my old S2 Skyrocket, S4, N7, and even on my S5 now.

I noticed that it almost always happens if I try to move the map, or zoom in/out, when data is still being loaded. it never seems to happen if I remember to wait until the data is fully loaded.

I always use the Google Maps view. I have not tried this on any other map layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment