add guessed level to player tracker #3

Closed
stighackvan opened this Issue Mar 20, 2013 · 4 comments

Comments

Projects
None yet
5 participants

breunings didn't like the idea, but I think it would be handy if both the player tracker and the level guesser externsions were installed, that the pop-up info on a player pin would include that player's guessed level.

I like this idea too.

Collaborator

jonatkins commented Mar 20, 2013

I like it too. I'll accept a patch for thus if it's reasonably clean and doesn't cause issues for either plugin on its own.

Contributor

vita10gy commented Mar 26, 2013

Issue #61

I'm guessing the main reason he didn't like it is because this kind of thing might open a can of worms regarding plugin dependencies. Although in this case it should be easy enough to fall back if guess player level isn't there, it is probably a rabbit hole that, in general, we should avoid leaping down.

I visit github and want to submit this idea. i am lucky to see that many people have done this. and found this request.

great...

jonatkins closed this Mar 29, 2013

@jonatkins jonatkins pushed a commit that referenced this issue Nov 27, 2013

@nexushoratio nexushoratio Merge pull request #3 from jonatkins/master
Pull from upstream.
0ddc8b5

@dingram dingram pushed a commit that referenced this issue Jun 13, 2016

@reckter reckter Merge pull request #3 from jonatkins/master
updating
e881429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment