Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issues in ornaments layers #1144

Merged
merged 7 commits into from Jan 10, 2017
Merged

Resolving issues in ornaments layers #1144

merged 7 commits into from Jan 10, 2017

Conversation

azack
Copy link
Contributor

@azack azack commented Nov 3, 2016

Builds on the work in open PR #1099 by resolving the fixing the variable typo and adds the requested layer for frackers. Tested in Chrome with local build and appears to work as expected.


window.ornaments.removePortal = function(portal) {
var guid = portal.options.guid;
if(window.ornaments._portals[guid]) {
window.ornaments._portals[guid].forEach(function(marker) {
window.ornaments._layer.removeLayer(marker);
window.ornaments._beacons.removeLayer(marker);
window.ornaments._frackers.removeLayer(marker);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm not certain of is this section: does removeLayer() complain if the marker was never part of that layer?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's a no-op

@dingram dingram merged commit a7edfef into iitc-project:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants