Code Refactoring #108
Merged
Code Refactoring #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PlashSpeed-Aiman
commented
Feb 13, 2024
PlashSpeed-Aiman
commented
- Added services class to encapsulate logic
- Moved calendar function to dedicated utils folder
## REFER TO ICALENDAR STANDARD FOR DETAILS This code is experimental several things need to be implemented for it to be complete: 1 ) Need to find out how to get the day for a given date, since ICS needs a specific date 2 ) recurring events works, even has a stop date. users should decide when to stop reminding. 3 ) replace the first code up until Future.wait to suit application needs.
` 1. Added services class to encapsulate logic 2. Moved calendar function to dedicated utils folder `
iqfareez
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.