[codex] Surface weather live fail-closed health#5
Merged
ijlu merged 1 commit intoMay 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
live_fc_missing_skipsto the existing[health] wx_handlerdaemon log line.[health] wx_live_fail_closedline for live v2 fair-value fail-closed events.WARNINGwhen nonzero, then reset the counter after each health emit.Why
Batch 3 made live weather quoting fail closed when required forecast/v2 inputs are unavailable. This follow-up makes those fail-closed paths visible in daemon health logs so operators can distinguish safe skipping from quiet inactivity.
Validation
python3 -m pytest tests/daemon/test_weather_live_health.py -q: 2 passedpython3 -m pytest tests/daemon/test_weather_live_health.py tests/daemon/test_weather_handler.py tests/test_weather_quoter.py tests/test_snapshot_writer_health.py -q: 138 passed.venv/bin/python -m pytest tests/ -q: 2376 passedNote:
python3 -m pytest tests/ -qwith the system Python failed during collection because the local systemcryptography/_cffi_backendwheel is x86_64 while this machine needs arm64. The repo.venvfull suite passed.Notes
Stacked on
codex/weather-live-fail-closed. No deploy or production data touched.