Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign measure to label bug #39

Open
tischi opened this issue Mar 27, 2020 · 5 comments
Open

Assign measure to label bug #39

tischi opened this issue Mar 27, 2020 · 5 comments
Assignees

Comments

@tischi
Copy link

tischi commented Mar 27, 2020

@dlegland @iarganda

The minimum value is not considered, but replaced by NaN.

For example:

image

Here 496 is the smallest value in the table but it will become NaN.

@tischi
Copy link
Author

tischi commented Mar 27, 2020

In addition, I do not understand why the user has to enter some values here at all.
The plugin could just replace all the label values of the measurement values.
If one wants to hide some values this could be done later using a threshold on the result image.

@dlegland
Copy link
Contributor

Hi @tischi ,
The aim of this plugin is to replace the label of each region with a value stored in a Table. If you obtain a NaN value, a possible reason is that the label exists in the label image but not in the results table.

From what I remember, the min and max values are used for calibrating display brightness / contrast, but I agree, this could be made outside of the plugin. I found this was easier to setup at this stage, as this can help use the same calibration for different images.

@tischi
Copy link
Author

tischi commented Mar 27, 2020

Hi @dlegland ,

It exists in the table. It is label number 8.

image

@tischi
Copy link
Author

tischi commented Mar 27, 2020

Maybe some issue with counting from zero instead of one?

@dlegland
Copy link
Contributor

hmm, strange... The value zero is associated to background, and corresponds to a NaN in the result image.
Also, you have labels in increasing order, without missing labels, so this should work perferctly...

I will check it...

@dlegland dlegland self-assigned this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants