New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMK colors are out of date. #169
Comments
AFAIK IJP has a fancy tool that analyzes the light coming off the key, and turns it into a colour code. So he will need a set of keys (or plastic samples)... taking colours off web photos is not accurate. |
Any chance you could update the GMK pallet if I provide the RGB values? I tried to do it using the chrome HTML editor but once I change everything it doesn't allow me to add the colors to the keyboard. |
Sorry, I have now mailed my contact at GMK to ask if they have the actual RGB values, taking them off a jpg will "work" but won't be completely accurate. You could always download the repo and run it locally, and then edit the file with the colours in. (colors.json). Note that AFAIK Ian Prest put the colour on the side of the key not the top. Just noticed the note in the file re GMK"s keys : "These are samples from a picture posted on GeekHack. No attempt at color-correction has been made." ... so I suppose your suggestion may work. Let's just wait a day or so to see if GMK comes back to me. I also need to hear from them if the previous range is discontinued. Will revert. Cheers, Ian |
I believe the previous colors are discontinued because they have changed plastic manufactures. I changed the colors.json to samples pulled from the tops of the caps in the pictures above but I couldn't be arsed to get a local site running.
|
GMK have come back to me, they're getting an engineer to get the proper RGB colour codes to send to me. Hopefully in the next few days. |
Awesome, thanks so much. |
Any update? |
Regret not yet, I'll send a followup next week. |
I followed up yesterday (apologies), my contact at GMK was on leave anyway and is back today. |
Scanning did not produce good results, I tried "colour analyser" apps on my phone but results were also not good. So resorted to taking pictures with a decent camera, that produces reasonable results. Done about half the keycaps, hope to have the rest done shortly. I'll send IJP a patch but he's been quiet lately so don't know when he will get it onto the live site. GMK sent me a link to their official pic of the keycaps, but the angle and lighting produce numerous colours on each surface, so I can't sample off that. |
BTW the stuff I'm working with is 35 colours, if I remember correctly... more than in your pic. Some are same as previous range. |
i cant wait for the new colors, im trying to make a mockup and updated colors would be great news :D |
These are the ones I have done so far. Still 9 to do. In a worst-case scenario you can manually set the colour on a key and they copy it to the others. Will try and finish this Tuesday. |
Im really new here, how do i use those codes? :)) |
For some reason the clever people who did HTML and CSS decided to have two different standards for specifying numbers... the numbers above are so-called RGB values, one each for Red, Green and Blue, on a scale of 0 - 255. Regarding the new colours, I added in the ones I photographed, but when I was checking them I noticed two things:
In the mean time I am happy with these: Will try and load and test the rest tomorrow. Cheers, Ian |
Thanks so much for this, they don't have to be 100% perfect as GMK offers renders once you get your set finalized. This tool is just a good way to visualize your set and make quick changes too it while being in the ballpark for color. |
Mmm... do you perhaps have a URL with such a render? thanks, Ian |
Here is a recent one I found https://www.keyclack.com/wp-content/uploads/2016/08/M8Oyad8.jpg |
Thanks, that looks like a photo not a render (ie computer-generated). I was hoping to be able to get them to create such a render and then borrow the colour codes. The 'photo' approach is not working too well .. colours do not come out accurate due to the plastic being shiny and reflecting the sunlight. So am busy with Plan B, which is to manually match the colour on screen to how it actually looks. Downside is that it's a slow and frustrating process, but at least the results are reasonable. |
Oh its a render alright, that set hasn't been produced yet. Thanks for all On Thursday, September 22, 2016, Ian Douglas notifications@github.com
|
I've mailed Jessica to ask if she has the colour codes, since she seems to make lots of mockups ... must have really fancy software. |
Which colours are most urgent? |
Personally, Im looking for their blacks, grays, and yellow, orange, red On Thursday, September 22, 2016, Ian Douglas notifications@github.com
|
Still busy but here's the colours you requested. They're at least reasonable if not perfect, and better than the existing codes (at least on my monitor and to my eyes :-) ) brown { "name": "BR1", "r":122, "g":91, "b":58 }, #7a5b3a More later... about 13 to go. Whites, blues/greens |
Thanks so much! I wonder if there is anyway to update the pallet locally so On Sun, Sep 25, 2016 at 2:07 PM, Ian Douglas notifications@github.com
|
Once you set the colour for a key, it is available in your "current key colors" in the Color Swatches. |
Damn. Thought I was done but looking at them in the palette some of them look wrong again. It's difficult to match pigment colours (reflected light) against screen colours (direct light). Whitish colours particularly tricky :-) |
Any update? |
Hi.. yeah... We had another go at the blues, greys and whites, but were not successful. Monitors not capable of displaying some colours, it seems. |
Where did this end up? Is KLE updated with the latest samples now? |
I sent them snailmail to IJP, and if I remember correctly, he scanned them with is fancy colour scanner identifier and updated them on KLE. It was almost three years ago ... |
Yes! Was completed in 69ef807. I neglected to close this out at the time. Raw photospectrometer data is here: https://docs.google.com/spreadsheets/d/1y3rkeCwR081D3reGhYMwmTfEn2CzF9ueALf8jwLuhEI |
The gmk color options are out of date.
Here is an image I got from GMK today.
http://imgur.com/ILNnXOm
Is there a way to get this updated?
The text was updated successfully, but these errors were encountered: