Permalink
Browse files

Check earlier for blocks with duplicate transactions. Fixes #1167

  • Loading branch information...
gavinandresen committed Apr 30, 2012
1 parent ec4997d commit be8651dde7b59e50e8c443da71c706667803d06d
Showing with 10 additions and 0 deletions.
  1. +10 −0 src/main.cpp
View
@@ -1652,6 +1652,16 @@ bool CBlock::CheckBlock() const
if (!tx.CheckTransaction())
return DoS(tx.nDoS, error("CheckBlock() : CheckTransaction failed"));
+ // Check for duplicate txids. This is caught by ConnectInputs(),
+ // but catching it earlier avoids a potential DoS attack:
+ set<uint256> uniqueTx;
+ BOOST_FOREACH(const CTransaction& tx, vtx)
+ {
+ uniqueTx.insert(tx.GetHash());
+ }
+ if (uniqueTx.size() != vtx.size())
+ return DoS(100, error("CheckBlock() : duplicate transaction"));
+
unsigned int nSigOps = 0;
BOOST_FOREACH(const CTransaction& tx, vtx)
{

0 comments on commit be8651d

Please sign in to comment.