Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ILDCellID0 with LCTrackerCellID #60

Merged
merged 1 commit into from Mar 24, 2017
Merged

Replace ILDCellID0 with LCTrackerCellID #60

merged 1 commit into from Mar 24, 2017

Conversation

eleogran
Copy link
Contributor

@eleogran eleogran commented Mar 23, 2017 •
edited by petricm

BEGINRELEASENOTES

  • Replace ILDCellID0 with LCTrackerCellID

ENDRELEASENOTES

gaede
gaede requested changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put back in this comment:

<!--- constants defined in class UTIL::ILDConfig  -->

it refers to the constants below in the compact files.
You can also simply reset all changes in the ILD/compact directory.
Thanks.

@eleogran
Copy link
Contributor Author

Fixed.
Do I need to open a new pull request?

gaede
gaede approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@gaede gaede merged commit 8883400 into key4hep:master Mar 24, 2017
@andresailer andresailer mentioned this pull request Mar 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaede gaede gaede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eleogran @gaede