Skip to content

Loading…

rapns fails to start on Heroku with ActiveRecord 3.2.5 #43

Closed
tompesman opened this Issue · 1 comment

2 participants

@tompesman

Due to this commit in ActiveRecord rapns fails to start with ActiveRecord 3.2.4/3.2.5 on Heroku.
rails/rails@8e315b0

lib/rapns/patches.rb:

if ActiveRecord::Base.configurations[Rails.env]['adapter'] == 'postgresql'

It fails as there is no 'configurations' available: lib/rapns/patches.rb:1:in '<top (required)>': undefined method '[]' for nil:NilClass (NoMethodError)

I don't have a pull request right now, but I think you should also check for the ENV['DATABASE_URL'].

@ileitch
Owner

Thanks, i'll get to this soon.

@ileitch ileitch closed this
@haslo haslo pushed a commit that referenced this issue
@taybenlor taybenlor Switch the order of checks for patching to support ActiveRecord 3.2.5…
… ref to [this issue](#43) in rapns.
0d60a0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.