"content-available"-flag added #68

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants

hi,

because i needed the "content-available"-flag in the APS array, i added it. you can merge it if you're interested!

  • clemens

This pull request fails (merged 56a5254 into 626d31f).

Owner

ileitch commented Sep 6, 2012

Could you please link me to the official Apple documentation for this? I'd like to understand it more before accepting any new code.

Owner

ileitch commented Sep 9, 2012

Thank you. I will implement this feature for 3.0, which I am currently working on (Google Cloud Messaging support, Android). I have a different approach in mind than a new column.

any news on this?

Owner

ileitch commented Oct 18, 2012

I haven't forgotten about this, I just haven't had much time to work on rapns recently.

The reason I haven't accepted this PR as-is is because there have been a couple of occasions thus far where new minor features required a new column. I'd rather not add a new column each time (it's annoying for people upgrading). I instead want to add a single internal column for things like this.

I plan to implement this for 3.0, which includes a large migration, so it makes sense to add it then.

ileitch closed this in a44d7ff Oct 19, 2012

@ileitch ileitch added a commit that referenced this pull request Oct 19, 2012

@ileitch ileitch Support content-available. Fixes #68. 83eef72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment