Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related [plugin incompatibility]: Call to undefined method Shaarli\Bookmark\BookmarkArray::getBookmarks() #20

Closed
voss opened this issue Jan 20, 2023 · 4 comments
Assignees
Labels

Comments

@voss
Copy link

voss commented Jan 20, 2023

Hi there,

Related looks like such an excellent plugin, and I really wanted to use it.

I just installed Shaarli 0.12.1 (the November 2020 release), and wanted to use your related plugin, so I installed by following the directions in the readme.

Upon loading the front page of my Shaarli installation, I get the error message as in the title of this issue:

related [plugin incompatibility]: Call to undefined method Shaarli\Bookmark\BookmarkArray::getBookmarks() 

From previous closed issue #18 that should fixed, but it appears the error is still there.

Best,

Jonas

@ilesinge
Copy link
Owner

Hello @voss,
Apparently when fixing #18 I forgot to push the right version!!
Thank you for letting me know, sorry for that.
If you retry with the latest version of the related plugin, it should work now :)

@ilesinge ilesinge added the bug label Jan 22, 2023
@ilesinge ilesinge self-assigned this Jan 22, 2023
@voss
Copy link
Author

voss commented Jan 22, 2023

Brilliant, thank you for the quick fix! (:

I downloaded it from the master.zip link in the readme, but that doesn't seem to be updated to reflect the fix. I still got the same error. I manually made the change in the downloaded version on line 88 in related.php to make it work.

I love this plugin, SO useful, when you have a ton of bookmarks in Shaarli. Thank you for building it (:

@voss
Copy link
Author

voss commented Jan 23, 2023 via email

@TheNomad11
Copy link

Working also fine with 0.12.2, thanks so much for keeping this valuable plugin up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants