feat(si): add specific power quantity #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific power is used to represent a power-to-weight ratio, like in vehicles or human power; as in watts per kilogram or ft-lbf/s per pound. Added the `SpecificPower` quantity using the existing `Power` quantity as a guideline. For more information on this quantity, please see a description of [specific power](https://en.wikipedia.org/wiki/Power-to-weight_ratio) on Wikipedia. Co-authored-by: Mike Boutin <mike.boutin@gmail.com>: * Various suggestions from code review (formatting, naming, remove unused units) * Formatting for readability. * Fix conversion factor used for pounds. * Check all units based on the units they are derived from. * Add `check_units_energy` test. Signed-off-by: Stephen Waits <steve@waits.net>
|
My repo was a mess. Just re-forked, applied the diff, and consolidated the commit messages. This is exactly what we had arrived at, but in a new PR. |
|
Kicked off the tests will do a final review tomorrow and hopefully merge! |
|
Thanks so much for the PR! |
|
Awesome, thanks! I'm excited to use the published crate in my project soon instead of my fork! 😃 |
|
I keep planning to do a release, but time always gets away from me. I'll see if I can make this week the week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific power is used to represent a power-to-weight ratio, like in vehicles or human power; as in watts per kilogram or ft-lbf/s per pound.
Added the
SpecificPowerquantity using the existingPowerquantity as a guideline.For more information on this quantity, please see a description of specific power on Wikipedia.
Co-authored-by: Mike Boutin mike.boutin@gmail.com:
check_units_energytest.Signed-off-by: Stephen Waits steve@waits.net