New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter adds new question, new queue, or new course #126

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@emilojkovic
Collaborator

emilojkovic commented Apr 25, 2018

No description provided.

@emilojkovic

This comment has been minimized.

Collaborator

emilojkovic commented Apr 25, 2018

So it appears that the test cases use submitButton.simulate('click') which does not actually submit the form. I found a fix to this ( see airbnb/enzyme#308) to change the test cases to use form.simulate('submit'). Making change in test cases for review :)

emilojkovic and others added some commits Apr 25, 2018

@nwalters512

Yay! A few things:

We don't want a page reload whenever a submit occurs. The right way to handle this would be to add an event argument to handleSubmit and call event.preventDefault() to prevent the browser from doing an actual POST once our handler executes.

Another thing I noticed was that validation errors, e.g. "You must name this queue" are no longer shown, even when you just press the "Create" button. Can you look into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment