Skip to content

Commit

Permalink
14092 imc(7D) should not be under i86pc
Browse files Browse the repository at this point in the history
Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
Reviewed by: Andy Fiddaman <andy@omnios.org>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Dan McDonald <danmcd@joyent.com>
  • Loading branch information
rmustacc committed Dec 3, 2021
1 parent eb96f8f commit 74079a5
Show file tree
Hide file tree
Showing 15 changed files with 35 additions and 34 deletions.
2 changes: 1 addition & 1 deletion usr/src/cmd/fm/mcdecode/Makefile
Expand Up @@ -26,7 +26,7 @@ ROOTLIBFMD = $(ROOT)/usr/lib/fm/fmd
ROOTPROG = $(ROOTLIBFMD)/$(PROG)

$(NOT_RELEASE_BUILD)CPPFLAGS += -DDEBUG
CPPFLAGS += -I$(SRC)/uts/i86pc/io/imc
CPPFLAGS += -I$(SRC)/uts/intel/io/imc
LDLIBS += -lnvpair

CSTD = $(CSTD_GNU99)
Expand Down
15 changes: 6 additions & 9 deletions usr/src/pkg/manifests/driver-cpu-mc.p5m
Expand Up @@ -19,15 +19,12 @@ set name=pkg.summary value="CPU Memory Controller Drivers"
set name=pkg.description value="CPU Memory Controller Drivers"
set name=info.classification value=org.opensolaris.category.2008:System/Hardware
set name=variant.arch value=i386
dir path=platform group=sys
dir path=platform/i86pc group=sys
dir path=platform/i86pc/$(ARCH64) group=sys
dir path=platform/i86pc/kernel group=sys
dir path=platform/i86pc/kernel/drv group=sys
dir path=platform/i86pc/kernel/drv/$(ARCH64) group=sys
file path=platform/i86pc/kernel/drv/$(ARCH64)/imc group=sys
file path=platform/i86pc/kernel/drv/$(ARCH64)/imcstub group=sys
file path=platform/i86pc/kernel/drv/imc.conf group=sys
dir path=kernel group=sys
dir path=kernel/drv group=sys
dir path=kernel/drv/$(ARCH64) group=sys
file path=kernel/drv/$(ARCH64)/imc group=sys
file path=kernel/drv/$(ARCH64)/imcstub group=sys
file path=kernel/drv/imc.conf group=sys
dir path=usr/share/man
dir path=usr/share/man/man7d
file path=usr/share/man/man7d/imc.7d
Expand Down
2 changes: 1 addition & 1 deletion usr/src/test/os-tests/tests/imc/Makefile
Expand Up @@ -39,7 +39,7 @@ include $(SRC)/cmd/Makefile.cmd
include $(SRC)/test/Makefile.com
include $(SRC)/cmd/Makefile.ctf

CPPFLAGS += -I$(SRC)/uts/i86pc/io/imc
CPPFLAGS += -I$(SRC)/uts/intel/io/imc

CMDS = $(PROG:%=$(TESTDIR)/%)
$(CMDS) := FILEMODE = 0555
Expand Down
7 changes: 0 additions & 7 deletions usr/src/uts/i86pc/Makefile.files
Expand Up @@ -321,10 +321,3 @@ ASSYM_DEPS += \
CPR_IMPL_OBJS = cpr_impl.o cpr_wakecode.o

$(KDI_ASSYM_DEPS:%=$(OBJS_DIR)/%): $(DSF_DIR)/$(OBJS_DIR)/kdi_assym.h

#
# Intel Integrated Memory Controller
# (Sandy Bridge - Cascade Lake)
#
IMC_OBJS = imc.o imc_decode.o imc_dump.o
IMCSTUB_OBJS = imcstub.o
1 change: 0 additions & 1 deletion usr/src/uts/i86pc/Makefile.i86pc
Expand Up @@ -245,7 +245,6 @@ DRV_KMODS += amd_iommu
DRV_KMODS += dr
DRV_KMODS += ioat
DRV_KMODS += fipe
DRV_KMODS += imc imcstub
DRV_KMODS += vmm
DRV_KMODS += viona
DRV_KMODS += ppt
Expand Down
8 changes: 0 additions & 8 deletions usr/src/uts/i86pc/Makefile.rules
Expand Up @@ -121,14 +121,6 @@ $(OBJS_DIR)/%.o: $(UTSBASE)/i86pc/io/ioat/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)

$(OBJS_DIR)/%.o: $(UTSBASE)/i86pc/io/imc/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)

$(OBJS_DIR)/%.o: $(SRC)/common/mc/imc/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)

$(OBJS_DIR)/%.o: $(UTSBASE)/i86pc/io/pci/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)
Expand Down
7 changes: 7 additions & 0 deletions usr/src/uts/intel/Makefile.files
Expand Up @@ -351,3 +351,10 @@ AMDZEN_STUB_OBJS = amdzen_stub.o
SMNTEMP_OBJS = smntemp.o
USMN_OBJS = usmn.o
ZEN_UDF_OBJS = zen_udf.o

#
# Intel Integrated Memory Controller
# (Sandy Bridge - Cascade Lake)
#
IMC_OBJS = imc.o imc_decode.o imc_dump.o
IMCSTUB_OBJS = imcstub.o
5 changes: 5 additions & 0 deletions usr/src/uts/intel/Makefile.intel
Expand Up @@ -738,3 +738,8 @@ DRV_KMODS += smntemp
DRV_KMODS += amdzen
DRV_KMODS += amdzen_stub
DRV_KMODS += usmn zen_udf

#
# Intel Integrated Memory Controller
#
DRV_KMODS += imc imcstub
8 changes: 8 additions & 0 deletions usr/src/uts/intel/Makefile.rules
Expand Up @@ -157,6 +157,14 @@ $(OBJS_DIR)/%.o: $(UTSBASE)/intel/io/hotplug/pcicfg/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)

$(OBJS_DIR)/%.o: $(UTSBASE)/intel/io/imc/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)

$(OBJS_DIR)/%.o: $(SRC)/common/mc/imc/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)

$(OBJS_DIR)/%.o: $(UTSBASE)/intel/io/ipmi/%.c
$(COMPILE.c) -o $@ $<
$(CTFCONVERT_O)
Expand Down
Expand Up @@ -17,10 +17,10 @@ UTSBASE = ../..

MODULE = imc
OBJECTS = $(IMC_OBJS:%=$(OBJS_DIR)/%)
ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)
CONF_SRCDIR = $(UTSBASE)/i86pc/io/imc
ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE)
CONF_SRCDIR = $(UTSBASE)/intel/io/imc

include $(UTSBASE)/i86pc/Makefile.i86pc
include $(UTSBASE)/intel/Makefile.intel

ALL_TARGET = $(BINARY) $(CONFMOD)
INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE)
Expand All @@ -40,4 +40,4 @@ clobber: $(CLOBBER_DEPS)

install: $(INSTALL_DEPS)

include $(UTSBASE)/i86pc/Makefile.targ
include $(UTSBASE)/intel/Makefile.targ
Expand Up @@ -17,9 +17,9 @@ UTSBASE = ../..

MODULE = imcstub
OBJECTS = $(IMCSTUB_OBJS:%=$(OBJS_DIR)/%)
ROOTMODULE = $(ROOT_PSM_DRV_DIR)/$(MODULE)
ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE)

include $(UTSBASE)/i86pc/Makefile.i86pc
include $(UTSBASE)/intel/Makefile.intel

ALL_TARGET = $(BINARY)
INSTALL_TARGET = $(BINARY) $(ROOTMODULE)
Expand All @@ -38,4 +38,4 @@ clobber: $(CLOBBER_DEPS)

install: $(INSTALL_DEPS)

include $(UTSBASE)/i86pc/Makefile.targ
include $(UTSBASE)/intel/Makefile.targ
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 74079a5

Please sign in to comment.