Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link target #546

Merged
merged 4 commits into from Sep 21, 2021
Merged

Link target #546

merged 4 commits into from Sep 21, 2021

Conversation

loesler
Copy link
Collaborator

@loesler loesler commented Oct 26, 2020

add target attribute to links in entries depending on the user preferences
work in progress

- add or remove link target depending on user preferences given by `user_settings["open_links_in_new_window"]`, cf. https://mylittleforum.net/forum/index.php?id=12381
- add includes prototype to support IE
@loesler loesler added this to the 2.5 milestone Oct 26, 2020
@loesler loesler self-assigned this Oct 26, 2020
- corrected case name, NON --> NONE
@auge8472
Copy link
Collaborator

I merged PR #550 a few minutes ago. Please take a last look to compare the JS-code my PHP-code generates and if it will work with your code.

- rename array user_settings to settings
- added target argument in function setLinkTarget
@loesler
Copy link
Collaborator Author

loesler commented Sep 21, 2021

I merged PR #550 a few minutes ago. Please take a last look to compare the JS-code my PHP-code generates and if it will work with your code.

I changed the array name and renamed user_settings to settings

@loesler loesler marked this pull request as ready for review September 21, 2021 19:46
@loesler loesler merged commit 880e69f into master Sep 21, 2021
@loesler loesler deleted the link_target branch September 21, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants