Clean up discovery.xml #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorth
force-pushed
the
5_x-discovery-cleanup
branch
2 times, most recently
from
717bb34
to
218069f
Compare
alanorth
force-pushed
the
5_x-discovery-cleanup
branch
from
218069f
to
7b5cde0
Compare
|
Hmm, the commit that changes some filters from First, with the modified filters:
Second, without:
I need to delete that commit, but otherwise the other two are fine. |
alanorth
force-pushed
the
5_x-discovery-cleanup
branch
from
7b5cde0
to
cd0b56f
Compare
The DSpace manual says that this property is not used for date facets because dates are automatically grouped.
On CGSpace the status field is either "Open Access" or "Limited Access", so we are never expecting more than two values here. If there are more values for some reason, they will be hidden behind a "View more" link anyways.
alanorth
force-pushed
the
5_x-discovery-cleanup
branch
from
cd0b56f
to
a04eada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to
discovery.xmlafter reading the DSpace manual:facetLimitfor date facets (they are automatically grouped by year, regardless of this setting)facetLimitfor accessibility status facet, as we only expect two values there, and anything else is an error and should not be displayedUseDiscoverySearchFilterclass for filters that aren't being used as facets