From 993ed32bd8312595c4394bd7821248e67a7600d3 Mon Sep 17 00:00:00 2001 From: Harshal <37841724+harshalkh@users.noreply.github.com> Date: Wed, 27 Oct 2021 22:35:57 +0530 Subject: [PATCH 1/2] Update App.java Sonar issue fix --- .../src/main/java/com/iluwatar/factory/method/App.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/factory-method/src/main/java/com/iluwatar/factory/method/App.java b/factory-method/src/main/java/com/iluwatar/factory/method/App.java index b76a918d1876..45e2dc10db92 100644 --- a/factory-method/src/main/java/com/iluwatar/factory/method/App.java +++ b/factory-method/src/main/java/com/iluwatar/factory/method/App.java @@ -41,6 +41,7 @@ @Slf4j public class App { + private static final String MANUFACTURED = "{} manufactured {}"; /** * Program entry point. * @param args command line args @@ -49,14 +50,14 @@ public static void main(String[] args) { Blacksmith blacksmith = new OrcBlacksmith(); Weapon weapon = blacksmith.manufactureWeapon(WeaponType.SPEAR); - LOGGER.info("{} manufactured {}", blacksmith, weapon); + LOGGER.info(MANUFACTURED, blacksmith, weapon); weapon = blacksmith.manufactureWeapon(WeaponType.AXE); - LOGGER.info("{} manufactured {}", blacksmith, weapon); + LOGGER.info(MANUFACTURED, blacksmith, weapon); blacksmith = new ElfBlacksmith(); weapon = blacksmith.manufactureWeapon(WeaponType.SPEAR); - LOGGER.info("{} manufactured {}", blacksmith, weapon); + LOGGER.info(MANUFACTURED, blacksmith, weapon); weapon = blacksmith.manufactureWeapon(WeaponType.AXE); - LOGGER.info("{} manufactured {}", blacksmith, weapon); + LOGGER.info(MANUFACTURED, blacksmith, weapon); } } From 66e6d7a8931b5531c17107c857d5462bb1fb9397 Mon Sep 17 00:00:00 2001 From: Harshal <37841724+harshalkh@users.noreply.github.com> Date: Wed, 27 Oct 2021 22:44:39 +0530 Subject: [PATCH 2/2] Update App.java --- .../src/main/java/com/iluwatar/factory/method/App.java | 1 + 1 file changed, 1 insertion(+) diff --git a/factory-method/src/main/java/com/iluwatar/factory/method/App.java b/factory-method/src/main/java/com/iluwatar/factory/method/App.java index 45e2dc10db92..d903ee7c7fee 100644 --- a/factory-method/src/main/java/com/iluwatar/factory/method/App.java +++ b/factory-method/src/main/java/com/iluwatar/factory/method/App.java @@ -42,6 +42,7 @@ public class App { private static final String MANUFACTURED = "{} manufactured {}"; + /** * Program entry point. * @param args command line args