From bb79e072c1fc96a4bab35a4a4f9277ce06b18312 Mon Sep 17 00:00:00 2001 From: Ilya Glotov Date: Thu, 27 Dec 2018 00:28:24 +0300 Subject: [PATCH] Reduce checkResponse code complexity --- cortex.go | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/cortex.go b/cortex.go index 89d6851..a8a5ba0 100644 --- a/cortex.go +++ b/cortex.go @@ -260,15 +260,14 @@ func (c *Client) Do(ctx context.Context, req *http.Request, v interface{}) (*htt // checkResponse checks http response status code and returns an error if // needed. func checkResponse(r *http.Response) error { - switch r.StatusCode { - case http.StatusOK: + if r.StatusCode == http.StatusOK { return nil - default: - var em errorMessage - err := json.NewDecoder(r.Body).Decode(&em) - if err != nil { - return fmt.Errorf(errUnknownFmt, r.Status) - } - return fmt.Errorf(errMessageFmt, r.Status, em.Type, em.Message) } + + var em errorMessage + err := json.NewDecoder(r.Body).Decode(&em) + if err != nil { + return fmt.Errorf(errUnknownFmt, r.Status) + } + return fmt.Errorf(errMessageFmt, r.Status, em.Type, em.Message) }