Permalink
Browse files

Make shared so library versioned.

  • Loading branch information...
ilyak committed Nov 15, 2017
1 parent 05d5c09 commit 1d4462c0ea6fd0cc4d6df082759d52b5242e2349
Showing with 2 additions and 1 deletion.
  1. +2 −1 CMakeLists.txt
View
@@ -49,7 +49,8 @@ string(REGEX REPLACE "([^;]+)" "${src_prefix}\\1" sources_list "${raw_sources_li
# STATIC/SHARED on below governed by BUILD_SHARED_LIBS
add_library(efp ${sources_list})
set_target_properties(efp PROPERTIES POSITION_INDEPENDENT_CODE ${BUILD_FPIC}
COMPILE_FLAGS "-std=c99")
COMPILE_FLAGS "-std=c99"
SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR})
if(${BUILD_SHARED_LIBS})
target_link_libraries(efp PRIVATE ${LIBC_INTERJECT})
if(APPLE)

3 comments on commit 1d4462c

@susilehtola

This comment has been minimized.

Show comment
Hide comment
@susilehtola

susilehtola Nov 15, 2017

Well, I guess this is one solution, but it's quite annoying for distribution maintainers. What this means is that even if the API doesn't change in a libefp update, we'll still have to rebuild all depending packages.

susilehtola replied Nov 15, 2017

Well, I guess this is one solution, but it's quite annoying for distribution maintainers. What this means is that even if the API doesn't change in a libefp update, we'll still have to rebuild all depending packages.

@ilyak

This comment has been minimized.

Show comment
Hide comment
@ilyak

ilyak Nov 15, 2017

Owner
Owner

ilyak replied Nov 15, 2017

@loriab

This comment has been minimized.

Show comment
Hide comment
@loriab

loriab Nov 21, 2017

Contributor

Not that I know much about SO versioning (if anyone has a link to best practices that's longer than a paragraph and shorter than a treatise, point me to it), but I've observed it changing much slower than API versioning. And if core things like /lib64/libc.so.6 glibc have only made it to 6 and haven't used minor, I don't think libefp needs it.

@bennybp, do you know the conventions?

Contributor

loriab replied Nov 21, 2017

Not that I know much about SO versioning (if anyone has a link to best practices that's longer than a paragraph and shorter than a treatise, point me to it), but I've observed it changing much slower than API versioning. And if core things like /lib64/libc.so.6 glibc have only made it to 6 and haven't used minor, I don't think libefp needs it.

@bennybp, do you know the conventions?

Please sign in to comment.