Skip to content

Add url support - #74

Merged
ilyakaznacheev merged 4 commits into
ilyakaznacheev:masterfrom
padawin:add-url-support
Jun 10, 2022
Merged

Add url support#74
ilyakaznacheev merged 4 commits into
ilyakaznacheev:masterfrom
padawin:add-url-support

Conversation

@padawin

@padawin padawin commented May 20, 2021

Copy link
Copy Markdown
Contributor

First off, thanks for this package!

I wanted to use it in our project, but we have in our environment a few URLs (DB connection strings in a single value, or URL for an image CDN for example), which should be valid ones.
It felt to me a fairly valid case to have as supported type, so here's a PR for it!

@codecov

codecov Bot commented May 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #74 (742f90d) into master (fb86a33) will increase coverage by 0.15%.
The diff coverage is 90.90%.

❗ Current head 742f90d differs from pull request most recent head 79612be. Consider uploading reports for the commit 79612be to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   90.07%   90.23%   +0.15%     
==========================================
  Files           1        1              
  Lines         252      256       +4     
==========================================
+ Hits          227      231       +4     
  Misses         17       17              
  Partials        8        8              
Impacted Files Coverage Δ
cleanenv.go 90.23% <90.90%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d3a3d...79612be. Read the comment docs.

@padawin
padawin force-pushed the add-url-support branch from 43d42fb to 742f90d Compare May 20, 2021 07:28
@padawin
padawin marked this pull request as draft May 20, 2021 07:29
@padawin
padawin marked this pull request as ready for review May 20, 2021 09:31

@ilyakaznacheev ilyakaznacheev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks like a really useful feature.

Please fix a couple of details before the merge.

Comment thread cleanenv.go
Comment thread cleanenv.go Outdated
Comment thread cleanenv.go Outdated
Comment thread example_test.go Outdated
@padawin

padawin commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

I'm sorry, my github notifications fell through the cracks apparently, and I completely forgot about this PR and did not see the comments.

I will tackle them ASAP!

@padawin

padawin commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

Here they are, let me know if you are happy with them!

@ilyakaznacheev ilyakaznacheev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it took me some time

@ilyakaznacheev
ilyakaznacheev merged commit 55f3daa into ilyakaznacheev:master Jun 10, 2022
@ilyakaznacheev

Copy link
Copy Markdown
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants