Add url support - #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 90.07% 90.23% +0.15%
==========================================
Files 1 1
Lines 252 256 +4
==========================================
+ Hits 227 231 +4
Misses 17 17
Partials 8 8
Continue to review full report at Codecov.
|
ilyakaznacheev
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks like a really useful feature.
Please fix a couple of details before the merge.
|
I'm sorry, my github notifications fell through the cracks apparently, and I completely forgot about this PR and did not see the comments. I will tackle them ASAP! |
cbc56ee to
d644186
Compare
d644186 to
60b5134
Compare
60b5134 to
79612be
Compare
|
Here they are, let me know if you are happy with them! |
ilyakaznacheev
left a comment
There was a problem hiding this comment.
Well, it took me some time
|
Thanks for your contribution! |
First off, thanks for this package!
I wanted to use it in our project, but we have in our environment a few URLs (DB connection strings in a single value, or URL for an image CDN for example), which should be valid ones.
It felt to me a fairly valid case to have as supported type, so here's a PR for it!