Option to ignore ancillary chunks with invalid CRC #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping non-critical chunks if the CRC check fails is the default it libpng. Therefore adding this option and enabling it by default. image-rs/image#2057
sophie-h
commented
Nov 18, 2023
fintelia
approved these changes
Nov 26, 2023
Got the original image form the issue report licensed under CC0 and it's small. So a regression test should be simple now. |
sophie-h
added a commit
to sophie-h/image-png
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping non-critical chunks if the CRC check fails is the default it libpng. Therefore adding this
option and enabling it by default.
image-rs/image#2057