Update next with latest changes to master #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace try! macros with ? operators
…fetime Remove unnecessary lifetime
Move travis notifications to gitter
Add Clippy to Travis
Remove unused lzw dependency
Provide bits_per_pixel and num_components as ColorType methods
png: Fix decoder off-by-1 error
Format code by rustfmt
Co-authored-by: martinlindhe
A somewhat long outstanding feature. The previous pub attribute on the function may have made it confusing and wrongly suggested that this was already the case. Closes: image-rs#978
Dynimage from decoder
Fix tiff magic bytes
Fix few clippy warnings
Update crate metadata for release 0.22.2
Fix the WebP spelling in README
Does not touch the public interface, only internal `_impl` variants which are simply referenced from their new location.
Firstly, simply renames load to decode. Also splits open into to operations: - open, which will inspect the file contents to guess the correct format *before* falling back to a path. - from_path, which imitates the old behaviour.
Don't deprecate them just yet, for now they are even the underlying primitives instead of being wrappers around the reader.
Fixes guess_format to only change the format on successful guesses.
Minimize the commitment of public interface for now. The builder style methods are likely the most immediately useful.
Failure that occurs only on nightly seems to be more often due to Rust breakage than a bug. Take deprecation warnings more serious by actively denying them which warns us of incompatible future versions as nightly would. Note: May remove this again in the future if it doesn't help. We've already had the case where the rustc version commitment left us without a proper replacement for a while since that had only been introduce shortly before deprecation. Also ensures that tests are ran on all relevant builds instead of only on nightly.
For osx and windows targets build with the first env combination since they are matrix includes. This ensures that this selects the build script with default features instead of no features.
Checks if a variable was declared, not if it has a non-empty content.
The core operation `${VARNAME+word}` will equal `word` if `VARNAME` is
set and non-null and be empty otherwise.
```
DEFAULT_FEATURES=''
[ -z "$DEFAULT_FEATURES" ] # true
```
```
DEFAULT_FEATURES=''
[ -n "${DEFAULT_FEATURES+exists}" ] # false
```
Align travis build to actions
gitignore: ignore target as a symlink
An array is indexed with constants that exceed its size. This is inopportune even in a branch that never gets executed. This changes it so that the indexing happens on a slice. Also removes a bunch of annotations by avoiding primitive casts with explicit type annotations in constants.
Fix strict const_err
Use `match` instead of `if-else` chain
Lints do affects downstream libraries if they use `image` as a path dependency. Due to the spread of the library it seems somewhat likely to be the case somewhere.
Bump version and changelog for v0.22.3
|
Seems reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the amount of final merges lower. This updates a few dependencies and Travis-CI scripts as well as better compatibility with
nightly.Also syncs up the introduced methods on
ColorType:channel_countinstead ofnum_componentsas it was determined to align toPixeltraitAdds the
io::Readerstructure for experimentation.