/ image Public
Add PngDecoder::with_limits #1812
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This isn't the most elegant solution given that other decoders use
ImageDecoder::set_limits, but idiosyncrasies of the PNG format make that interface non-ideal. Specifically, finding out whether the image is animated (contains an acTL chunk) or has a "simple alpha channel" (contains a tRNS chunk) potentially requires scanning a nearly unbounded number of chunks. Worse, we currently don't have a Seek bound on the reader, so we have to store all the chunks we read in case we need them later.