Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper FileNotFoundError, pathlib support #308

Merged
merged 9 commits into from Feb 19, 2018
Merged

proper FileNotFoundError, pathlib support #308

merged 9 commits into from Feb 19, 2018

Conversation

@scivision
Copy link
Contributor

@scivision scivision commented Feb 18, 2018

Python's FileNotFoundError is for non-existent directories and files.

Moreover, as of Python 3.3, IOError has been merged into OSError, and may eventually be deprecated.

It was very surprising to me to have IOError raised for a missing file or directory, as every other module I've used uses the appropriate FileNotFoundError.

Additionally, added pathlib support, which is Python standard library since Python 3.5.

@coveralls
Copy link

@coveralls coveralls commented Feb 18, 2018

Coverage Status

Coverage decreased (-0.01%) to 93.088% when pulling 2f75965 on scivision:master into b122f91 on imageio:master.

scivision added 6 commits Feb 18, 2018
@scivision scivision changed the title proper FileNotFound exception for imread proper FileNotFoundError, pathlib support Feb 18, 2018
scivision and others added 2 commits Feb 18, 2018
@almarklein almarklein merged commit 787d8a0 into imageio:master Feb 19, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@almarklein
Copy link
Member

@almarklein almarklein commented Feb 19, 2018

Thanks for these improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants