Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof ij1-patcher for ImageJ 1.49m #32

Merged
merged 1 commit into from
Dec 3, 2014
Merged

Future-proof ij1-patcher for ImageJ 1.49m #32

merged 1 commit into from
Dec 3, 2014

Conversation

dscho
Copy link
Contributor

@dscho dscho commented Dec 3, 2014

This commit addresses the problem arising from ImageJ's version 1.49m
simply moving the JavaScriptEvaluator class into the ij.plugin package
with the following explanation:

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de

This commit addresses the problem arising from ImageJ's version 1.49m
simply moving the JavaScriptEvaluator class into the ij.plugin package
with the following explanation:

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Contributor Author

dscho commented Dec 3, 2014

The symptom:

java.lang.IllegalArgumentException: Cannot modify method: public void run()
    at net.imagej.patcher.CodeHacker.insertAtTopOfMethod(CodeHacker.java:167)
    at net.imagej.patcher.LegacyExtensions.injectHooks(LegacyExtensions.java:229)
    ...
Caused by: java.lang.IllegalArgumentException: No such class: JavaScriptEvaluator
    at net.imagej.patcher.CodeHacker.getClass(CodeHacker.java:880)
    at net.imagej.patcher.CodeHacker.getMethod(CodeHacker.java:906)
    at net.imagej.patcher.CodeHacker.getBehavior(CodeHacker.java:896)
    at net.imagej.patcher.CodeHacker.insertAtTopOfMethod(CodeHacker.java:158)
    ... 34 more
Caused by: javassist.NotFoundException: JavaScriptEvaluator
    at javassist.ClassPool.get(ClassPool.java:450)
    at net.imagej.patcher.CodeHacker.getClass(CodeHacker.java:875)
    ... 37 more

ctrueden added a commit that referenced this pull request Dec 3, 2014
Future-proof ij1-patcher for ImageJ 1.49m
@ctrueden ctrueden merged commit cf922b1 into master Dec 3, 2014
@ctrueden
Copy link
Member

ctrueden commented Dec 3, 2014

Thanks @dscho!

@ctrueden ctrueden deleted the ij-1.49m branch December 3, 2014 17:32
@dscho
Copy link
Contributor Author

dscho commented Dec 3, 2014

You're welcome @ctrueden. In general, I contribute the fixes I make during my regular work back to the projects I am benefitting from, and with you as maintainer, it is very pleasant to contribute, too.

@ctrueden
Copy link
Member

ctrueden commented Dec 3, 2014

FTR, this change also fixes Fiji bug #964!

@ctrueden
Copy link
Member

And now, the fix is available via the Help > Update command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants