New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate net.imagej.table.* in favour of org.scijava.table.* #78

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@imagejan
Copy link
Member

imagejan commented Aug 12, 2018

Note that ResultsTable and DefaultResultsTable as well as TableService and DefaultTableService have not been deprecated. Instead, their API changed from net.imagej.table.Table to org.scijava.table.Table.
In addition, DefaultTableDisplay has been reduced to a stub, as functionality for displaying 1D and 2D double arrays is now in org.scijava.table.DefaultTableDisplay.

These changes require increasing the major version (or minor as we are pre-1.0.0).

Deprecate net.imagej.table.* in favour of org.scijava.table.*
Note that ResultsTable and DefaultResultsTable as well as TableService and DefaultTableService have _not_ been deprecated. Instead, their API changed from net.imagej.table.Table to org.scijava.table.Table.
In addition, DefaultTableDisplay has been reduced to a stub, as functionality for displaying 1D and 2D double arrays is now in org.scijava.table.DefaultTableDisplay.

These changes require increasing the major version (or minor as we are pre-1.0.0).

@imagejan imagejan force-pushed the scijava-table branch from bd29a79 to fcaa211 Aug 15, 2018

@imagejan

This comment has been minimized.

Copy link
Member Author

imagejan commented Aug 15, 2018

I amended the commit and also deprecated the DisplayViewer-related classes in net.imagej.ui.viewer.table.*.

The replacements are implemented in scijava-table.

This should be good to go now from my side.

@ctrueden ctrueden merged commit 50b5cc6 into master Aug 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ctrueden ctrueden deleted the scijava-table branch Aug 20, 2018

@ctrueden

This comment has been minimized.

Copy link
Member

ctrueden commented Aug 20, 2018

Thanks very much for following through on this, @imagejan! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment