Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--update is broken on Windows #10

Open
hinerm opened this issue Jun 10, 2014 · 5 comments
Open

--update is broken on Windows #10

hinerm opened this issue Jun 10, 2014 · 5 comments
Labels

Comments

@hinerm
Copy link
Member

hinerm commented Jun 10, 2014

If I run ImageJ-win64.exe --update update to update Fiji from the command line, it just does nothing with no output right now.

If I run ImageJ-win64.exe --debug --update update, it works! and now finds the things to update, and asks what I'd like to do with them..

@hinerm
Copy link
Member Author

hinerm commented Jun 10, 2014

Note that "works!" is subjective, due to #11

@ctrueden
Copy link
Member

It is worth noting that this seems to be more than just a logging issue. Even if you run:

ImageJ-win64.exe -Dscijava.log.level=info -- --update update

It still does nothing. But with --debug it works. My theory is that somewhere, there is logic like:

if (log.isDebug()) {
    doSomethingThatShouldNotHaveSideEffectsButActuallyDoes();
}

@hinerm
Copy link
Member Author

hinerm commented Jun 10, 2014

Also the no output may be partially related to #9 ... except that in the case of --update update I think it needs to be in debug mode to work at all, so even with -Dscijava.log.level=info nothing is printed out.. you have to set --debug

@dscho
Copy link
Contributor

dscho commented Jun 10, 2014

Probably we need to force --system on Windows when the updater is called :-(

@dscho
Copy link
Contributor

dscho commented Jun 11, 2014

My findings: the --update update actually worked, it just happened not needing to do anything. The output was swallowed by the aforementioned problem: we cannot easily attach to a console from a running non-console executable. There is code to do that; I suspect 32-bit vs 64-bit to be the reason why it did not work.

So the safest way forward is probably to enforce --system with --console on Windows...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants