Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegacyService dispose code is fragile #1

Closed
ctrueden opened this Issue May 3, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@ctrueden
Copy link
Member

ctrueden commented May 3, 2014

The DefaultLegacyService dispose() method closes all windows before shutting down IJ1. However the code that closes all windows can fail. You can see this by inspecting IJ1's source code. The closeAllWindows() command relies on the idea that Editor windows with changes will not close without saving first. Right now if a legacy plugin opens a Editor window and changes its text then the closeAllWindows() should fail. We might need some CodeHacker or reflection code for setting Editor's changed flag to false.

Migrated-From: http://trac.imagej.net/ticket/1836

@ctrueden

This comment has been minimized.

Copy link
Member Author

ctrueden commented Sep 1, 2016

Much work was done to reliably dispose all open windows, both image and non-image:

So the only potentially remaining rogue windows are those which some ImageJ plugin created and showed but did not register with ImageJ1's WindowManager. So far, we have no had problems in practice with such windows. And if we do, the proper fix is probably to correct the code of the plugin in question.

@ctrueden ctrueden closed this Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.