Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for legacy layer #6

Open
ctrueden opened this Issue May 6, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@ctrueden
Copy link
Member

commented May 6, 2014

We need to verify that the legacy layer is translating data correctly. We should write unit tests for the layer. However some final testing cannot take place until headless UIs are in place. Right now the code is tied to ImageDisplays which don't yet exist in a well initialized headless UI.

Migrated-From: http://trac.imagej.net/ticket/833

@dscho

This comment has been minimized.

Copy link
Member

commented May 26, 2014

I vote for closing this because the UI will change, still, and when it does, we will implement those unit tests.

@ctrueden

This comment has been minimized.

Copy link
Member Author

commented May 26, 2014

Well, what we really should be unit testing is the translation between IJ1 and IJ2. I don't care as much about "unit testing" how the LegacyUI itself behaves. Sure, yes, it would be nice. But the primary critical code to test is that data structures can be transformed back and forth successfully.

Looking at the code, we have a few tests in place, but are clearly missing many key tests. The code in LegacyImageMapTest has also been disabled for a long time now with FIXMEs.

So I think to resolve this ticket, we need to add at least some rudimentary "down the middle" testing in both directions between IJ1 and IJ2 with respect to images and maybe other data structures too.

None of this for June 1 though.

@dscho dscho modified the milestone: imagej-2.0.0 May 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.