Reinstate ImageJ 1.x' "single instance listener" #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it has to be static so that we can call `subscribeEvents()` even before the LegacyService has been fully initialized. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Awesome that Zeiss sponsored this! 👍 All in all, looks pretty good. I made some minor comments. My more serious concern is that this feature was reintroduced completely at the ImageJ1 level in this imagej-legacy component, rather than being done purely as a SciJava feature. It would be a useful feature even if the ImageJ1 legacy layer is not present or enabled, but with the current implementation, would not be available in that scenario, which is a shame. Perhaps someday it can be refactored to remove ImageJ1-isms from the core functionality, and migrated into SciJava Common where it belongs. In the meantime, it gets the job done for Zeiss et. al, so if you address the small concerns I'll merge it. |
They repeated code. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
In ImageJ1, there is an option in Options>Misc...>Run single instance listener; When checked, it tells ImageJ1 to look for an existing ImageJ instance when starting up, and passing the command-line options if one is found. We will reinstate that functionality in the next few commits and need to prepare the IJ1Helper for that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The purpose of this class -- which we now call SingleInstance because it is more appropriate -- is to start an Remote Method Invocation (RMI) server when ImageJ is started, listening for commands being sent by subsequent invocations of the ImageJ executable. Essentially, it makes ImageJ a singleton, when that "Run single instance listener" option is checked. We still need to *use* this class, of course, which is the purpose of the next commit. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This patch introduces a ConsoleService that overrides the default console service so that we can quit when an ImageJ instance was detected and the command line parameters have been handed off. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Due to recent changes in the `openImage()` method, images are not shown when loaded as long as the UI is not shown. This is the case when images are loaded as part of command line parameter parsing. Let's force images to be shown when we know that the UI will be shown eventually. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
ImageJ should be called in batch mode when run in a headless environment, of course, but even if batch mode is off, we should not show images when we're headless. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We never know which ConsoleService has the next lower priority, until we ask the ServiceIndex. So we model the consoleService() method after SCIFIO's DatasetService strategy. Pointed out by Curtis Rueden. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
single-instance-listener
branch
from
9ce6b70
to
ffe4e71
Compare
|
Updated PR. |
ctrueden
added a commit
that referenced
this pull request
Jun 30, 2015
Reinstate ImageJ 1.x' "single instance listener"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ImageJ 1.x, there is an option Options>Misc...>Run single instance listener; When checked, it tells ImageJ to look for an existing ImageJ instance when starting up, and passing the command-line options if one is found. Essentially, it makes ImageJ behave like a singleton.
This Pull Request reinstates that functionality and fixes a few issues related to it. The work has been sponsored by Zeiss Deutschland to ensure interoperability between Fiji and ZEN.