Do not let the usage statistics prevent bare .class plugins from running #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctrueden could you have a look at this? Hopefully this will fix Aryeh's problem... |
There is a "cute" logic in ImageJ 1.x allowing to run bare .class plugins even if they are in subdirectories of the plugins/ directory. This requires some hackery to work, thanks to the ImageJ 1.x patcher. But as long as that hackery has not been run, the class cannot be run properly. For the moment, simply ignore such plugin classes when gathering usage statistics. This should fix http://fiji.sc/bugzilla/show_bug.cgi?id=891 reported by Aryeh Weiss. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
ctrueden
added a commit
that referenced
this pull request
Aug 11, 2014
Do not let the usage statistics prevent bare .class plugins from running
|
Thanks @dscho, I expanded the comment in the catch block to be more explanatory, like your commit message. But I think we do want to ignore plugins in bare class files, anyway. If someone cares that their plugin have usage statistics online, they can care enough to package it in a .jar file! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a "cute" logic in ImageJ 1.x allowing to run bare .class plugins
even if they are in subdirectories of the plugins/ directory. This
requires some hackery to work, thanks to the ImageJ 1.x patcher. But as
long as that hackery has not been run, the class cannot be run properly.
For the moment, simply ignore such plugin classes when gathering usage
statistics.
This should fix http://fiji.sc/bugzilla/show_bug.cgi?id=891 reported by
Aryeh Weiss.
Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de