New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new equation ops #396
Add new equation ops #396
Conversation
Add ops for calibrated equations (AbstractCalibratedEquation.java), equations passed in using an op (DefaultCalibratedEquation.java), and equations passed in using a binary lambda (DefaultXYCalibratedEquation.java).
That is hot! Will review after I return home from traveling. Or @dietzc
feel free to merge sooner if you like it!
|
@@ -58,7 +62,7 @@ | |||
@OpMethod(op = net.imagej.ops.image.ascii.DefaultASCII.class) | |||
public <T extends RealType<T>> String ascii(final IterableInterval<T> image) { | |||
final String result = (String) ops().run( | |||
net.imagej.ops.Ops.Image.ASCII.class, image); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
several format changes in this file make it hard to review the actual changes. can you undo the format changes and commit only thing related to the functionality you added/changed? I know it's a bit annoying, but it helps in the long run :-)
I added some comments about the coding style itself, but didn't have time to check the actual functionality in detail. maybe @ctrueden can quickly do that. |
Sorry, some urgent priorities have come up. I will not have time to look at this for some weeks now. |
I suggest to wait with the merge until we finally decided how we represent calibrated images in the future. |
Add ops for calibrated equations (AbstractCalibratedEquation.java), equations passed in using an op (DefaultCalibratedEquation.java), and equations passed in using a binary lambda
(DefaultXYCalibratedEquation.java).
This allows me to implement equations fairly easily. For example:
or (since origin and calibration are optional)