Interval functionality for various Transform Ops #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelfrich
reviewed
Jul 12, 2017
| @@ -235,6 +238,10 @@ private int pseudoRandom() { | |||
| } | |||
| assertFalse("More elements than expected", a.hasNext()); | |||
| } | |||
|
|
|||
| public static <T> RandomAccessible<T> deinterval(RandomAccessibleInterval<T> input){ | |||
| return Views.extendBorder(input); | |||
There was a problem hiding this comment.
Looking at where this method is used, replacing the original casts with calls to it seems legit. In general, however, this is not the case: with L243 you are replacing an already existing OutOfBoundsFactory of input with an OutOfBoundsBorderFactory.
There was a problem hiding this comment.
@stelfrich How would you suggest it be changed?
There was a problem hiding this comment.
@ctrueden No changes, since it seems to be the only alternative to replacing the casts.
ctrueden
force-pushed
the
issue-486
branch
2 times, most recently
from
29baac0
to
2ff87f2
Compare
stelfrich
reviewed
Jul 19, 2017
| public void testDefaultRotate() { | ||
| final Img<DoubleType> img = new ArrayImgFactory<DoubleType>().create(new int[] { 20, 10 }, new DoubleType()); | ||
|
|
||
| final MixedTransformView<DoubleType> il2 = Views.rotate((RandomAccessible<DoubleType>) img, 1, 0); |
There was a problem hiding this comment.
Also use deinterval? (applies to other tests as well...)
Removes the intervals on a RandomAccessibleInterval
This was removed since it was never matched and it was redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch solves issue #486 by adding Interval functionality for the Rotate and Hyperslice ops. The branch also adds Interval functionality for the Permute, InvertAxis, Subsample and Translate ops.
This branch also fixes a Transform Namespace bug. Previously, the Transform Namespace was not being tested correctly because it was looking for ops in the "View" namespace, which does not exist.
Finally this branch removes the DefaultScaleView and renames WrappedScaleView as the new DefaultScaleView. This was done due to the redundancy between the two ops and due to the fact that DefaultScaleView would never be called.
Closes #486.