Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation message after sample image is uploaded #7

Closed
hinerm opened this issue Jun 19, 2014 · 1 comment
Closed

Add a confirmation message after sample image is uploaded #7

hinerm opened this issue Jun 19, 2014 · 1 comment
Assignees

Comments

@hinerm
Copy link
Member

hinerm commented Jun 19, 2014

The SampleImageUploader doesn't provide the best feedback when an image completes.

It looks like it's using the StatusService, but it would be nice to provide a pop-up dialog at completion, with a message indicating the result of the upload request.. maybe also with the final URL of the image as well?

Several users have said either a) nothing happened after uploading (even though it did work) or b) they weren't sure when the process completed.

ctrueden added a commit that referenced this issue Jun 24, 2014
This may be a stopgap solution until we have a better TaskService in
place (imagej/ImageJ#25). But until that time,
it is nice to show a clear dialog box upon either success _or_ failure.

We show the box only in the run() method itself, so that other potential
uses of the API are not infected with calls to the UIService.

Fixes issue #7.
@dscho
Copy link
Contributor

dscho commented Jun 24, 2014

Fixed by #8.

@dscho dscho closed this as completed Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants