Skip to content
Permalink
Browse files

Mark @parameters private in UpdatesAvailable

The original idea was that we wanted to re-use this class in Fiji
where no context was available at the time.

In the meantime, there *is* an ImageJ2 context available, so we do not
need to play games with setting fields of commands by hand anymore,
i.e. there is no need for the fields to be public anymore.

Careful analysis of both fiji.git and imagej.git shows that this
plugin was never used in Fiji, so let's simply make those fields
private. No harm done.

Noticed by Barry DeZonia.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information...
dscho committed Jul 23, 2013
1 parent 2337f34 commit ecfc68b6186db2f0eed716363e8283a3dec8ab09
Showing with 2 additions and 2 deletions.
  1. +2 −2 core/updater/src/main/java/imagej/updater/ui/UpdatesAvailable.java
@@ -61,10 +61,10 @@
LATER = "Remind me later";

@Parameter
public CommandService commandService;
private CommandService commandService;

@Parameter
public LogService log;
private LogService log;

@Parameter(label = "Do you want to start the Updater now?", choices = { YES,
NEVER, LATER })

0 comments on commit ecfc68b

Please sign in to comment.
You can’t perform that action at this time.