Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyline tool to Swing UI #58

Merged
merged 1 commit into from Mar 26, 2014

Conversation

Projects
None yet
3 participants
@bnanes
Copy link
Contributor

commented Mar 21, 2014

Similar to SwingPolygonTool, but uses a BezierFigure that is open rather
than closed and a GeneralPathOverlay instead of a PolygonOverlay.

Add polyline tool to Swing UI
Similar to SwingPolygonTool, but uses a BezierFigure that is open rather
than closed and a GeneralPathOverlay instead of a PolygonOverlay.
@dscho

This comment has been minimized.

Copy link
Member

commented Mar 21, 2014

Looks very good to me! Only question: should we retain the Line tool at all, then?

@bnanes

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2014

I think it’s probably worth keeping the Line tool for two reasons.

  • First, ImageJ1 has both line and polyline tools, so keeping the line tool would be more consistent.
  • Second, since LineOverlay and LineRegionOfInterest are rather different from GeneralPathOverlay and GeneralPathRegionOfInterest, making both accessible through the UI would provide better support for development of commands that want to make use of one or the other (for example, point-to-point measurement might only use LineRegionOfInterest while scanning along a path might use GeneralPathRegionOfInterest).
@dscho

This comment has been minimized.

Copy link
Member

commented Mar 26, 2014

Okay. @ctrueden are you okay with merging this? I am in favor!

@ctrueden

This comment has been minimized.

Copy link
Member

commented Mar 26, 2014

I have no objections! Thanks for the contribution, @bnanes.

One thing to be aware of, though, @bnanes: ImageJ2's focus for 2014 is on better integration with the ImageJ1 user interface. We are targeting a stable release of the ImageJ2 core (i.e., version 2.0.0) for this summer. But that will only involve bringing ij-core out of beta, not ij-data or ij-ui or the "modern" Swing UI. So while this change benefits the modern UI, it will have no effect on the IJ1 interface, which will continue to be the default interface for at least another year...

ctrueden added a commit that referenced this pull request Mar 26, 2014

Merge pull request #58 from bnanes/polyline
Add polyline tool to Swing UI

@ctrueden ctrueden merged commit 9e5e54a into imagej:master Mar 26, 2014

@ctrueden

This comment has been minimized.

Copy link
Member

commented May 3, 2014

For the record, this enhancement closed Trac ticket #943.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.