New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GradientImage example has style issues #10

Closed
ctrueden opened this Issue Aug 18, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@ctrueden
Member

ctrueden commented Aug 18, 2014

In the tutorial code we have a simple command example. It creates a GradientImage. However the code example uses bad style in that it is somewhat dependent upon the expectation that the created Img is backed by PlanarAccess. It uses setPlane(). This is to show users that they can ignore our generic types. But for the June 2013 beta release (beta 7) we are thinking that the Img creating/opening code will work in CellImgs depending upon the size of the Img. So we shouldn't encourage users to rely on setPlane(). Or we need to change its contract.

Migrated-From: http://trac.imagej.net/ticket/1850

@stelfrich stelfrich self-assigned this Jun 13, 2016

@stelfrich

This comment has been minimized.

Member

stelfrich commented Jun 13, 2016

I will take care of this when RichImg (or whatever it may be called)/ImgPlus/Dataset has settled.

Should we already introduce Ops for creating images in this tutorial?

@ctrueden

This comment has been minimized.

Member

ctrueden commented Feb 10, 2017

This is technically still an issue. But it will become moot soon, because the simple-commands tutorial is going away in favor of Beaker notebooks, which do not use the undesirable Dataset API. Closing preemptively, since no further action will be required to solve this later.

@ctrueden ctrueden closed this Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment