Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases & onError & onSuccess callbacks #3

Merged
merged 43 commits into from Mar 23, 2020
Merged

Test cases & onError & onSuccess callbacks #3

merged 43 commits into from Mar 23, 2020

Conversation

@MrDHat
Copy link
Member

MrDHat commented Mar 5, 2020

No description provided.

src/helpers/urlGenerators.js Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
utkace and others added 12 commits Mar 16, 2020
Copy link
Contributor

imagekitio left a comment

The retuned element is enclosed in a div. It should be just an image tag.

exports[`Storyshots IKImage Image With LQIP With Nested Path 1`] = `
<div>
  <img
    class="ik-image"
    src="https://ik.imagekit.io/your_imagekit_id/tr:q-20,h-300,w-400/sample-folder/default-image.jpg?ik-sdk-version=vuejs-1.0.3"
  />
</div>
`;
Copy link
Contributor

imagekitio left a comment

<IKImage
      publicKey="publicKey"
      :urlEndpoint="urlEndpoint"
      :src="src"
      queryParameters="{param1:'value1'}"
    />

The above returns

<div><img src="https://ik.imagekit.io/pshbwfiho/test_image_hvR29yIZY.jpg?ik-sdk-version=vuejs-1.0.3&amp;0=%7B&amp;1=p&amp;2=a&amp;3=r&amp;4=a&amp;5=m&amp;6=1&amp;7=%3A&amp;8=%27&amp;9=v&amp;10=a&amp;11=l&amp;12=u&amp;13=e&amp;14=1&amp;15=%27&amp;16=%7D" class="ik-image"></div>
@utkace

This comment has been minimized.

Copy link
Collaborator

utkace commented Mar 19, 2020

<IKImage
      publicKey="publicKey"
      :urlEndpoint="urlEndpoint"
      :src="src"
      :queryParameters="{param1:'value1'}"
    />

The above returns

<div><img src="https://ik.imagekit.io/pshbwfiho/test_image_hvR29yIZY.jpg?ik-sdk-version=vuejs-1.0.3&amp;0=%7B&amp;1=p&amp;2=a&amp;3=r&amp;4=a&amp;5=m&amp;6=1&amp;7=%3A&amp;8=%27&amp;9=v&amp;10=a&amp;11=l&amp;12=u&amp;13=e&amp;14=1&amp;15=%27&amp;16=%7D" class="ik-image"></div>

Missing the colon in queryParameters prop, you need to v-bind the prop

@imagekitio imagekitio merged commit 524ee78 into master Mar 23, 2020
3 checks passed
3 checks passed
build (8.x)
Details
build (10.x)
Details
build (12.x)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.