Fix/plumbing Hero#87
Merged
Merged
Conversation
Add missing margin-top:0 and padding-top:var(--wp--preset--spacing--large) to the stats row container's inline style to match the block attributes, resolving the block validation content mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release patches a block validation mismatch in the Home Improvement vertical's hero pattern and bumps the theme version to 4.3.1. The stats row container in
plumbing-hero.phpdeclaredmargin-top:0andpadding-top:var:preset|spacing|largein its block attributes JSON, but the serialized HTMLstyleattribute omitted both properties, causing a content mismatch that WordPress's JS block validator would flag on save. The fix aligns the inline style string with the declared block attributes, resolving the validation error without altering any layout or visual output. Version metadata has been updated acrossstyle.css,readme.txt, andCHANGELOG.mdto reflect the patch release.Bug Fix — Plumbing Hero Pattern:
wp:groupcontainer inpatterns/plumbing-hero.phpto includemargin-top:0andpadding-top:var(--wp--preset--spacing--large)in the serializedstyleattribute, matching the block's declared"spacing":{"margin":{"top":"0"},"padding":{"top":"var:preset|spacing|large",...}}attributes and eliminating a JS block validation mismatch.parse_blocks()accepted the pattern without error (Pass 1), but the Gutenberg JS serializer expected the inline style to reflect all declared spacing properties — a class of issue only caught by the sentinel runtime validator (Pass 3).Version Bump and Release Metadata:
style.cssandreadme.txt(Stable tag), following the established patch-release convention for targeted bug fixes.CHANGELOG.mdupdated with a new[4.3.1] - 2026-05-22section documenting the root cause, the missing inline style properties, and the block attribute mismatch context.Files Changed:
CHANGELOG.md(Modified)patterns/plumbing-hero.php(Modified)readme.txt(Modified)style.css(Modified)