Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 9 / clang 9 compatibility #1058

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@lgritz
Copy link
Member

commented Sep 12, 2019

Only one extra #if this time to make it work with LLVM 9.0 (currently in release candidate), and compiling with clang9 seemed to work without changes.

There are a few SPI-specific makefile fixes.

@fpsunflower

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

LGTM!

@lgritz lgritz merged commit 00984c3 into imageworks:master Sep 12, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lgritz lgritz deleted the lgritz:lg-llvm9 branch Sep 13, 2019
lgritz added a commit to lgritz/OpenShadingLanguage that referenced this pull request Sep 13, 2019
lgritz added a commit to lgritz/OpenShadingLanguage that referenced this pull request Sep 13, 2019
lgritz added a commit to lgritz/OpenShadingLanguage that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.