Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake and CI overhaul #1072

Merged
merged 1 commit into from Nov 7, 2019
Merged

CMake and CI overhaul #1072

merged 1 commit into from Nov 7, 2019

Conversation

@lgritz
Copy link
Member

lgritz commented Oct 30, 2019

I prototyped all this stuff in OIIO over the last month, and now am
finally porting the methodology to OSL. Major changes:

  • Bump CMake minimum to 3.12

  • Massive refactor of cmake files to move to modern idioms and best
    practices. Beware some changed conventions for controlling the build:

    • CMAKE_CXX_STANDARD instead of USE_CPP
    • CXX_VISIBILITY_PRESET instead of HIDESYMBOLS
    • BUILD_SHARED_LIBS instead of BUILDSTATIC
    • Package_ROOT to hint where to find dependencies, instead of
      some random selection of PACKAGEHOME, PACKAGE_ROOT_DIR, etc.
  • Start using GitHub CI.

@lgritz lgritz force-pushed the lgritz:lg-cmake branch from f29a56d to 0e52371 Oct 30, 2019
I prototyped all this stuff in OIIO over the last month, and now am
finally porting the methodology to OSL. Major changes:

* Bump CMake minimum to 3.12

* Massive refactor of cmake files to move to modern idioms and best
  practices. Beware some changed conventions for controlling the build:
    - CMAKE_CXX_STANDARD instead of USE_CPP
    - CXX_VISIBILITY_PRESET instead of HIDESYMBOLS
    - BUILD_SHARED_LIBS instead of BUILDSTATIC
    - Package_ROOT to hint where to find dependencies, instead of
      some random selection of PACKAGEHOME, PACKAGE_ROOT_DIR, etc.

* Start using GitHub CI.
@lgritz lgritz force-pushed the lgritz:lg-cmake branch from 0e52371 to 2b008cc Oct 31, 2019
@lgritz lgritz merged commit d3206b9 into imageworks:master Nov 7, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lgritz lgritz deleted the lgritz:lg-cmake branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.