Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCMake and CI overhaul #1072
Merged
CMake and CI overhaul #1072
Conversation
I prototyped all this stuff in OIIO over the last month, and now am
finally porting the methodology to OSL. Major changes:
* Bump CMake minimum to 3.12
* Massive refactor of cmake files to move to modern idioms and best
practices. Beware some changed conventions for controlling the build:
- CMAKE_CXX_STANDARD instead of USE_CPP
- CXX_VISIBILITY_PRESET instead of HIDESYMBOLS
- BUILD_SHARED_LIBS instead of BUILDSTATIC
- Package_ROOT to hint where to find dependencies, instead of
some random selection of PACKAGEHOME, PACKAGE_ROOT_DIR, etc.
* Start using GitHub CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lgritz commentedOct 30, 2019
I prototyped all this stuff in OIIO over the last month, and now am
finally porting the methodology to OSL. Major changes:
Bump CMake minimum to 3.12
Massive refactor of cmake files to move to modern idioms and best
practices. Beware some changed conventions for controlling the build:
some random selection of PACKAGEHOME, PACKAGE_ROOT_DIR, etc.
Start using GitHub CI.