Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for date format in gemspec #29

Merged
merged 1 commit into from Aug 1, 2011

Conversation

Projects
None yet
2 participants
Contributor

msolli commented Aug 1, 2011

Hi

This change fixes a problem with the date specification in the gemspec.

This line in the gemspec caused problems for me on August 1st:
gemspec.date = "#{Time.now.year}-#{Time.now.month}-#{Time.now.day}"

The resulting string would be "2011-8-1", which of course is an invalid date specification:

/Users/martin/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:990:in `date=': invalid date format in specification: "2011-8-1" (Gem::InvalidSpecificationException)
    from /Users/martin/.rvm/gems/ruby-1.9.2-p180@thalamus/bundler/gems/fancy-buttons-66ddfffa237a/fancy-buttons.gemspec:7:in `block in <main>'
…

imathis added a commit that referenced this pull request Aug 1, 2011

Merge pull request #29 from msolli/master
Fix for date format in gemspec

@imathis imathis merged commit 189fac1 into imathis:master Aug 1, 2011

Owner

imathis commented Aug 1, 2011

Thanks. Does this interfere with being able to use Fancy Buttons or just being able to build it?

Contributor

msolli commented Aug 1, 2011

Dang, that was fast! :)

Yeah, I couldn't bundle install it from my app, Bundler was choking on the date format.

Owner

imathis commented Aug 1, 2011

Good to know I'll do a point release. Thanks again!

Owner

imathis commented Aug 1, 2011

Sorry for the delay. Fixed version pushed. Thanks for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment