Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for date format in gemspec #29

Merged
merged 1 commit into from

2 participants

@msolli

Hi

This change fixes a problem with the date specification in the gemspec.

This line in the gemspec caused problems for me on August 1st:
gemspec.date = "#{Time.now.year}-#{Time.now.month}-#{Time.now.day}"

The resulting string would be "2011-8-1", which of course is an invalid date specification:

/Users/martin/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:990:in `date=': invalid date format in specification: "2011-8-1" (Gem::InvalidSpecificationException)
    from /Users/martin/.rvm/gems/ruby-1.9.2-p180@thalamus/bundler/gems/fancy-buttons-66ddfffa237a/fancy-buttons.gemspec:7:in `block in <main>'
…
@imathis imathis merged commit 189fac1 into from
@imathis
Owner

Thanks. Does this interfere with being able to use Fancy Buttons or just being able to build it?

@msolli

Dang, that was fast! :)

Yeah, I couldn't bundle install it from my app, Bundler was choking on the date format.

@imathis
Owner

Good to know I'll do a point release. Thanks again!

@imathis
Owner

Sorry for the delay. Fixed version pushed. Thanks for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 1, 2011
  1. @msolli

    Fix date format.

    msolli authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  fancy-buttons.gemspec
View
2  fancy-buttons.gemspec
@@ -4,7 +4,7 @@ require File.join(path, 'version')
Gem::Specification.new do |gemspec|
gemspec.name = "fancy-buttons"
gemspec.version = FancyButtons::VERSION # Update the VERSION.yml file to set this.
- gemspec.date = "#{Time.now.year}-#{Time.now.month}-#{Time.now.day}" # Automatically update for each build
+ gemspec.date = Time.now.strftime("%Y-%m-%d") # Automatically update for each build
gemspec.description = "Fancy Buttons helps you easily style buttons with beautiful CSS3 features like gradients, rounded corners, etc. Don't worry the buttons also degrade nicely for browsers with no support. This requires the Compass stylesheet authoring framework."
gemspec.homepage = "http://github.com/imathis/fancy-buttons"
gemspec.authors = ["Brandon Mathis"]
Something went wrong with that request. Please try again.