Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Zsh #117

Closed
Nerian opened this issue Aug 25, 2011 · 36 comments
Closed

Not compatible with Zsh #117

Nerian opened this issue Aug 25, 2011 · 36 comments

Comments

@Nerian
Copy link

@Nerian Nerian commented Aug 25, 2011

Hello,

The Rake task for creating a new post seems to be not compatible with Zsh.

rake new_post["Zombie Ninjas Attack: A survivor's retrospective"]   
zsh: no matches found: new_post[Zombie Ninjas Attack: A survivor's retrospective]
@zanshin
Copy link
Contributor

@zanshin zanshin commented Aug 25, 2011

You need to create an alias for rake in your .zshrc. Like this:

alias rake="noglob rake"

With that in place you'll be good to go.

@imathis
Copy link
Owner

@imathis imathis commented Aug 25, 2011

Thanks @zan5hin! I should add that to the setup docs!

@imathis imathis closed this Aug 25, 2011
@mysteriouspants
Copy link
Contributor

@mysteriouspants mysteriouspants commented Aug 25, 2011

If you don't feel like not globbing, the following works fairly well, too:

  rake "new_post[Zombie Ninjas Attack: A Pastafarian's Retrospective]"

It probably dies on a lot of characters, but if you're in a bind, it's better than nothing.

@Merovex
Copy link

@Merovex Merovex commented Sep 10, 2011

Had the same problem, the .zshrc fix did not work, but @nserror comment worked.

@imathis
Copy link
Owner

@imathis imathis commented Sep 10, 2011

That's pretty awful. Perhaps I should ditch the inline variable and make it a dialog?

rake new_post
Enter a post title:
@Nerian
Copy link
Author

@Nerian Nerian commented Sep 10, 2011

I like that idea

@ghost
Copy link

@ghost ghost commented Sep 18, 2011

I think a dialog prompt would be better as well. It seems to be unhappy with a bunch of the character combinations I've tried.

@ghost
Copy link

@ghost ghost commented Sep 18, 2011

For example, post titles with commas in them generate files that are truncated after the comma, likely as a result of how the [] expression is parsed. Unless I'm just too stupid to figure out how to properly escape it...

@imathis
Copy link
Owner

@imathis imathis commented Sep 18, 2011

I'm sorry for the annoyance, I didn't realize rake was so poor at arguments. This is on the list of coming attractions.

@zanshin
Copy link
Contributor

@zanshin zanshin commented Sep 19, 2011

I'm not able to create a posting with a comma either. Using a \ to escape the comma didn't help. If you do add a prompt for the post name, could that be optional? I.e., if I enter rake new_post["Some title"] have it work as it does not, but if I just enter rake new_post have it prompt me for the title?

@imathis
Copy link
Owner

@imathis imathis commented Sep 19, 2011

Yeah I don't want everyone to have to relearn how to post. If the args are empty it'll ask for a title. Good thought.

@mysteriouspants
Copy link
Contributor

@mysteriouspants mysteriouspants commented Sep 19, 2011

Calling downcase on the title when making the filename might be a good idea, too. ;-)

@mrcasals
Copy link

@mrcasals mrcasals commented Sep 28, 2011

I'm having the same trouble, and if I write rake new_post it just creates a new post titled "New post" and doesn't ask for the title as @imathis suggested... Any idea on when will it be implemented? :)

@imathis
Copy link
Owner

@imathis imathis commented Sep 28, 2011

I'm currently working full steam on getting the 2.1 release ready. It's going to be in there. Sorry for the delay. I'm hoping to have it up this weekend.

@mrcasals
Copy link

@mrcasals mrcasals commented Sep 28, 2011

Oh, nice to hear that! I'll wait, then :)

@fmeyer
Copy link

@fmeyer fmeyer commented Dec 10, 2011

Still not working without the external quotes. 👎

btw tks @nserror

@davidcelis
Copy link

@davidcelis davidcelis commented Jan 29, 2012

Sooooo what's the news on this?

@Merovex
Copy link

@Merovex Merovex commented Jan 29, 2012

Hmm... for my part I can say it all works for me with alias rake='noglob rake' I have the latest Octopress. The old dialog is still in place.

@davidcelis
Copy link

@davidcelis davidcelis commented Jan 29, 2012

The alias fixed it for me as well, but it would be nice for Cctopress to support zsh without us having to alias things in our shell. Just thought I'd give this issue a bump.

@Merovex
Copy link

@Merovex Merovex commented Jan 29, 2012

http://www.faqs.org/faqs/unix-faq/shell/zsh/

http://www.scottw.com/zsh-rake-parameters

The problem isn't Octopress, per se. The problem is globbing. I just tried to google the size of the problem, and found it virtually non-existent. So, I started looking at zsh more closely and happened upon this:

http://zsh.sourceforge.net/Doc/Release/Expansion.html#Filename-Generation

If a word contains an unquoted instance of one of the characters ‘’, ‘(’, ‘|’, ‘<’, *‘[’**, or ‘?’, it is regarded as a pattern for filename generation, unless the GLOB option is unset.

The issue is Octopress' rake command "rake new_post['his is a new post?']" contains an unquoted instance of [

Perhaps Octopress should have a command like?

rake new_post="This is a new post?"

But no, if you look at http://rake.rubyforge.org/files/doc/rakefile_rdoc.html (Tasks with Options) you see...

Just a few words of caution. The rake task name and its arguments need to be a single command line argument to rake. This generally means no spaces. If spaces are needed, then the entire rake + argument string should be quoted. Something like this:

   rake "name[billy bob, smith]"

So, even if zsh weren't a problem, it appears the proper command in Rake syntax should be:

rake "new_post[This is a new post?]"

Not only would that be canonical, it should also get around the zsh glob issue as the left square brace would be in quotes.

We are a victim of Rake's syntax, not Octopresses, I'm afraid. But, I like my non-globbed overlord.

@jmacdonald
Copy link

@jmacdonald jmacdonald commented Mar 1, 2012

I like the idea of a dialog/prompt for this; the resulting syntax is much more Rake-like and is much easier to remember.

@vodafon
Copy link

@vodafon vodafon commented Mar 27, 2012

rake new_post\["This is New Post"\] 

good work for me

@jtratner
Copy link

@jtratner jtratner commented May 16, 2012

I wrote a function to side-step this issue (and just do new-post "title"). https://gist.github.com/2708914 Handles the globbing issue too.

This tops the results on Google for "octopress and zsh" (and it's where I figured out how to resolve my problem), so I figured I'd leave this here for the benefit of future searchers. For everybody else, sorry about the notification spam!

@imathis
Copy link
Owner

@imathis imathis commented May 21, 2012

I've just added bfa5255 which asks for a post title from stein if you run new_post without a value.

vrdabomb5717 pushed a commit to vrdabomb5717/octopress that referenced this issue May 21, 2012
- Inline input as in `rake new_post["Your post title"]
- Input from stdin if in-line input isn't given.

This should help zhs users who've been frustrated by globbing issues.
Fixes imathis#117
@createbang
Copy link

@createbang createbang commented Jul 29, 2012

Definitely appreciate the .zshrc alias comment. Fixed the issue for me, too.

@westonplatter
Copy link

@westonplatter westonplatter commented Aug 7, 2012

@imathis per your bfa5255 commit, I tried, rake new_post and was not prompted for a title, but rather the title was automatically "new post" and the file was <date>-new-post.markdown.

Did you change this?

@imathis
Copy link
Owner

@imathis imathis commented Aug 18, 2012

@westonplatter Rake new_post has had defaults for a long time.

@atmosx
Copy link

@atmosx atmosx commented Sep 11, 2012

Latest version, used here with oh-my-zsh, some issues still persist:

➜  .octopress git:(master) ✗ rake new_post[\"test"\]
dquote>
➜  .octopress git:(master) ✗ rake "new_post[test]"
mkdir -p source/_posts
Creating new post: source/_posts/2012-09-11-test.markdown
➜  .octopress git:(master) ✗ rm source/_posts/2012-09-11-* 
➜  .octopress git:(master) ✗ rake "new_post[karida loaded!]"
zsh: event not found: ]
➜  .octopress git:(master) ✗ rake "new_post[karida loaded]"
mkdir -p source/_posts
Creating new post: source/_posts/2012-09-11-karida-loaded.markdown
➜  .octopress git:(master) ✗ 

I can't put special chars like: $!@#%^&.. in the title. But it's okay...

@zanshin
Copy link
Contributor

@zanshin zanshin commented Sep 11, 2012

Try creating an alias like this alias rake="noglob rake".

@atmosx
Copy link

@atmosx atmosx commented Sep 11, 2012

Already did that.

@kud
Copy link

@kud kud commented Sep 29, 2012

+1 for zsh support.

@chrishough
Copy link

@chrishough chrishough commented Dec 30, 2012

the alias rake="noglob rake" worked for me with iterm2 (zsh)

@freme
Copy link

@freme freme commented Oct 18, 2013

bundle exec rake "new_post[no special characters]"
was what i needed to run with rake 0.9.6 (using a oh-my-zsh and iterm2)

@ridwanahmedkhan
Copy link

@ridwanahmedkhan ridwanahmedkhan commented Aug 22, 2014

Had the same problem, the .zshrc fix did not work, but @nserror comment worked.thanks.

@strivingboy
Copy link

@strivingboy strivingboy commented Jun 17, 2015

thanks good work for me

@liuyix
Copy link

@liuyix liuyix commented Oct 20, 2015

I have the same problem, but using the alias rake="noglob rake" works fine. Putting this suggestion in the doc may be helpful for many folks :-)

paveg added a commit to paveg/dotfiles that referenced this issue Aug 24, 2019
paveg added a commit to paveg/dotfiles that referenced this issue Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.