Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pullquotes break on single-quotes #316

Closed
mattgemmell opened this Issue Dec 11, 2011 · 0 comments

Comments

Projects
None yet
2 participants

Pullquotes are (visually) prematurely terminated if they contain single-quotes, since the generated SPAN tag uses those as attribute delimiters and the content isn't pre-escaped. The pullquote itself should be escaped for single-quotes before the SPAN tag is generated.

@imathis imathis closed this in d5a02a7 Dec 11, 2011

@treyhunner treyhunner pushed a commit to treyhunner/octopress that referenced this issue Feb 26, 2012

@imathis imathis Added RubyPants (the ruby port of John Gruber's smarty pants) to inte…
…lligently replace primes with smart quotes in the pullquote plugin, fixes #316
2c91c27

@briansimmons briansimmons pushed a commit to briansimmons/octopress that referenced this issue Aug 20, 2013

@imathis imathis Added RubyPants (the ruby port of John Gruber's smarty pants) to inte…
…lligently replace primes with smart quotes in the pullquote plugin, fixes #316
58f9a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment