New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake: Add rakefile parameter to set git message #1693

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Erethon

Erethon commented Dec 5, 2014

Add a rakefile parameter called "message" to set a custom git commit
message for a deploy.

Example:

rake deploy message="This is a custom commit message"
rake: Add rakefile parameter to set git message
Add a rakefile parameter called "message" to set a custom git commit
message for a deploy.
@kindjar

This comment has been minimized.

kindjar commented Dec 5, 2014

I like this feature. However, now that you can have arbitrary text in the message, the call to system in line 266 should be converted to use the individual-arguments form rather than a single string with the entire command. Otherwise the custom message could encounter shell quoting issues and cause the message to run commands other than the git commit.

@imathis imathis force-pushed the imathis:master branch from 5ea6eba to 514ed5e Dec 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment