New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disqus identifier #277

Closed
wants to merge 1 commit into
base: site
from

Conversation

Projects
None yet
3 participants
@treyhunner
Copy link
Contributor

treyhunner commented Nov 15, 2011

Currently, if the site_url is different from root.url, comments on thread pages will still work, but comment counts on the homepage will not work.

This change fixes this issue by adding the canonical URL in the data-disqus-identifier attribute. If the post has a meta.disqus_id field this will be used to override this identifier instead. According to the documentation using the disqus identifier is the preferred method of identifying posts.

@imathis

This comment has been minimized.

Copy link
Owner

imathis commented Sep 30, 2012

Just added this into 2.1. Thanks :)

@imathis imathis closed this Sep 30, 2012

@parkr parkr reopened this Sep 30, 2013

@parkr parkr closed this Sep 30, 2013

parkr added a commit that referenced this pull request Sep 30, 2013

jhwist added a commit to jhwist/octopress that referenced this pull request Jan 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment