Tag cloud #282

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
@tedkulp
Contributor

tedkulp commented Nov 16, 2011

This is similar to categories, so much so that I wasn't sure if I should make a pull request or not. However, I did create a tag cloud aside that I've included. "tags" metadata is already included in Jekyll, so this wasn't much of a stretch to add. The only thing missing is the scss definition to make the classes in the cloud slightly bigger based on the popularity (rank-1 though rank-5), but it's easy enough to add.

@imathis

This comment has been minimized.

Show comment
Hide comment
@imathis

imathis Nov 16, 2011

Owner

Thanks for the pull request. I'll have a look over the next couple of days. (I'm just getting back into things after being out of town)

Owner

imathis commented Nov 16, 2011

Thanks for the pull request. I'll have a look over the next couple of days. (I'm just getting back into things after being out of town)

@simensen

This comment has been minimized.

Show comment
Hide comment
@simensen

simensen Nov 26, 2011

Contributor

I think this would be nice functionality to have. It would be easy enough to just add this (or another tag plugin) but supporting it by Octopress directly would be pretty nice.

Contributor

simensen commented Nov 26, 2011

I think this would be nice functionality to have. It would be easy enough to just add this (or another tag plugin) but supporting it by Octopress directly would be pretty nice.

@akuznecov

This comment has been minimized.

Show comment
Hide comment
@akuznecov

akuznecov Dec 15, 2011

spaces in URL should be also replaced with dash.
without it we will get a %20 in urls for multiword tags and 404 errors.
For example:
tags: [foo bar, lorem impus]
will cause urls http://site.domain/tag/foo%20bar, but in tag directory we have a foo-bar folder.

I have fixed it on my blog with:s << "<a href='/#{dir}/#{sorted[index][0].gsub(/_|\W/, '-')}'>#{sorted[index][0]}</a>"as in tag_generate.rb

spaces in URL should be also replaced with dash.
without it we will get a %20 in urls for multiword tags and 404 errors.
For example:
tags: [foo bar, lorem impus]
will cause urls http://site.domain/tag/foo%20bar, but in tag directory we have a foo-bar folder.

I have fixed it on my blog with:s << "<a href='/#{dir}/#{sorted[index][0].gsub(/_|\W/, '-')}'>#{sorted[index][0]}</a>"as in tag_generate.rb

@yyr

This comment has been minimized.

Show comment
Hide comment
@yyr

yyr Jan 11, 2012

If I may ask, what is the status of this pull.?

yyr commented Jan 11, 2012

If I may ask, what is the status of this pull.?

@seraphyn

This comment has been minimized.

Show comment
Hide comment
@seraphyn

seraphyn Jan 16, 2012

Would be nice to hear about the state +tedkulp

Would be nice to hear about the state +tedkulp

@ctoestreich

This comment has been minimized.

Show comment
Hide comment
@ctoestreich

ctoestreich Jan 20, 2012

Adding this to master would be AWESOME! I merged it manually to my source as tags are a must in most blog posts and navigation. @tedkulp Thanks for the hard work! BTW there are few missed changes in the pull request in the sass dir that you added for styling the css for posts in sass/partials/_blog.scss. Not sure if that was intentionally excluded or not.

Adding this to master would be AWESOME! I merged it manually to my source as tags are a must in most blog posts and navigation. @tedkulp Thanks for the hard work! BTW there are few missed changes in the pull request in the sass dir that you added for styling the css for posts in sass/partials/_blog.scss. Not sure if that was intentionally excluded or not.

@ctoestreich

This comment has been minimized.

Show comment
Hide comment
@ctoestreich

ctoestreich Jan 22, 2012

I submitted a pull request for this branch with few fixes in the code as well as added the missing tag cloud style elements into the css build tree so the tag cloud renders the tags by size relative to the main text.

I submitted a pull request for this branch with few fixes in the code as well as added the missing tag cloud style elements into the css build tree so the tag cloud renders the tags by size relative to the main text.

@tedkulp

This comment has been minimized.

Show comment
Hide comment
@tedkulp

tedkulp Jan 26, 2012

Contributor

Sorry I missed the pull request and this comment. It's merged in my branch now.

Contributor

tedkulp commented Jan 26, 2012

Sorry I missed the pull request and this comment. It's merged in my branch now.

@tedkulp

This comment has been minimized.

Show comment
Hide comment
@tedkulp

tedkulp Jan 27, 2012

Contributor

And now I realized that the auto-merge stuck it in the wrong branch. Will fix soon. Haven't had a ton of free time lately.

Contributor

tedkulp commented Jan 27, 2012

And now I realized that the auto-merge stuck it in the wrong branch. Will fix soon. Haven't had a ton of free time lately.

@teiko

This comment has been minimized.

Show comment
Hide comment
@teiko

teiko Feb 4, 2012

Small Question, shouldn't there be a change to the Rakefile for rake new_post to have a tags-definition like the categories one?
And _config.yml should have tag_title_prefix: Tag for changing the string used before the tag name in the page title ?

teiko commented Feb 4, 2012

Small Question, shouldn't there be a change to the Rakefile for rake new_post to have a tags-definition like the categories one?
And _config.yml should have tag_title_prefix: Tag for changing the string used before the tag name in the page title ?

@aderixon

This comment has been minimized.

Show comment
Hide comment
@aderixon

aderixon Mar 1, 2012

Needs to be tag.to_s.gsub to handle tags that are entirely numeric, otherwise "undefined method `gsub' for 1234:Fixnum (NoMethodError)" is thrown.

Needs to be tag.to_s.gsub to handle tags that are entirely numeric, otherwise "undefined method `gsub' for 1234:Fixnum (NoMethodError)" is thrown.

@imathis

This comment has been minimized.

Show comment
Hide comment
@imathis

imathis May 23, 2012

Owner

This is not something I would use, but I'm sure many would. I'd prefer not to merge it into the framework, but if you'd like to create a repo or gist for it and link to it from the 3rd party plugins page that would be great.

Owner

imathis commented May 23, 2012

This is not something I would use, but I'm sure many would. I'd prefer not to merge it into the framework, but if you'd like to create a repo or gist for it and link to it from the 3rd party plugins page that would be great.

@imathis imathis closed this May 23, 2012

@lukekhamilton

This comment has been minimized.

Show comment
Hide comment
@lukekhamilton

lukekhamilton Apr 30, 2013

Was this ever turned into a plugin?

Was this ever turned into a plugin?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 30, 2013

Collaborator

If it was, it should be listed on the page linked to in @imathis's comment above.

Collaborator

parkr commented Apr 30, 2013

If it was, it should be listed on the page linked to in @imathis's comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment